Compilation errors with rusqlite 0.29

[johnbcodes]

rusqlite has removed some deprecated items with 0.29, including NO_PARAMS in this commit.

Full compatibility also requires tokio-rusqlite to be updated for which a pull request has been submitted

[czocher]

Thanks @johnbcodes we'll have a look with @cljoly and see what we can do to stay compatible with the new versions of rusqlite, tokio-rusqlite and, if that's still possible, our MSRV which is Rust 1.61.0.

[cljoly]

Thanks for submitting the PR to tokio-rusqlite and for the research @johnbcodes !

I think that there are two problems here, and that we could tackle them separately.

Make rusqlite_migration compatible with latest dependencies

We want future versions of rusqlite_migration to be compatible with the latest versions of our dependencies. And I agree with you @czocher, as much as possible, we want to keep the same MSRV. If we have to increase it though, so be it, we can’t make any promise anyway as long as rusqlite does not make promises as well.

• I will create a separate issue to make sure that the latest version supports the right tokio-rusqlite versions to support rusqlite 0.29. Support and require rusqlite 0.29 in the next stable release (1.1.0) #69

Make rusqlite_migration properly express its dependencies

We want versions of rusqlite_migration to properly express their dependencies, i.e. if the user requests version 0.29 of rusqlite and rusqlite_migration is incompatible with it, we should get an error from the dependency solver, not a compilation error from the library.

In that regard, we currently have a bug in version 1.0.1 (and most of the previous ones IIRC), in that the Cargo.toml advertises that we support any version of rusqlite >= 0.23. That has become false with version 0.29 of rusqlite. And in general, it was a very hard promise to keep, because per Cargo conventions, rusqlite versions 0.28 and 0.29 are not necessarily compatible. It’s admittedly a mistake on my part, I should not have made a bold >= 0.23 promise.
To remediate this, we should:

• Express dependencies more tightly in the last supported release (edit: here is a PR with the proposed fix fix: adapt to rusqlite 0.29 and tighten the requirements #70)
• Moving forward, support only one version (edit: will be tackled as a part of Support and require rusqlite 0.29 in the next stable release (1.1.0) #69)

[cljoly]

TL;DR: if you encounter a compilation problem on rusqlite_migration in version 1.0.x, make sure you update to 1.0.2. This patch version supports rusqlite 0.29

Future versions will have much tighter dependency requirements, this is tracked in #69.