Prepare an alpha version without tokio features #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, CI output first flagged `clap`: ``` error: package `clap v4.5.13` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.70.0 Either upgrade to rustc 1.74 or newer, or use cargo update -p clap@4.5.13 --precise ver where `ver` is the latest version of `clap` supporting rustc 1.70.0 Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101 ``` Then rusqlite 0.32 uses a ructc-feature `c_literal` [commit], which has been stablized in 1.77.0. Second, Rust 1.77.0, went out almost 6 months ago at this point, so we are not going to require a very recent rust version. Note: Reworded based on this thread: #181 (comment) [commit] rusqlite/rusqlite@ed7434e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry picks some changes from #181 and updates the changelog, because these changes can live in the master branch. The intent is for the branch of
v1.3.0 Alpha-Without-Tokio 1to only carry the commits removing the actual feature.