Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace BTreeMap with Vec #92

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Replace BTreeMap with Vec #92

merged 1 commit into from
Jun 18, 2023

Conversation

czocher
Copy link
Collaborator

@czocher czocher commented Jun 17, 2023

Implements the performance improvements described in #85 i.e. replacing the BTreeMap with a Vec of Option.

Closes #85.

@czocher czocher requested a review from cljoly as a code owner June 17, 2023 22:39
cljoly
cljoly reviewed Jun 18, 2023
View reviewed changes
rusqlite_migration/src/loader.rs Outdated Show resolved Hide resolved
rusqlite_migration/src/loader.rs Show resolved Hide resolved
rusqlite_migration/src/loader.rs Outdated Show resolved Hide resolved
rusqlite_migration/src/loader.rs Outdated Show resolved Hide resolved
@cljoly cljoly mentioned this pull request Jun 18, 2023
Merged
cljoly
cljoly approved these changes Jun 18, 2023
View reviewed changes
Copy link
Owner

@cljoly cljoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@czocher czocher merged commit 7db47b3 into cljoly:master Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cljoly cljoly cljoly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Further improve performance of from_directory
2 participants
@czocher @cljoly