[AWS] Resolve Issue : Remove Print Statements and Check Log Level #1207 #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…240531_synn # Conflicts: # cloud-control-manager/cloud-driver/drivers/aws/resources/ClusterHandler.go
…40531_synn Issue 1207 fmt logger change 20240531 synn
powerkimhub
reviewed
Jul 2, 2024
| @@ -204,7 +203,7 @@ func ConvertToString(value interface{}) (string, error) { | |||
| // Cloud Object를 CB-KeyValue 형식으로 변환이 필요할 경우 이용 | |||
| func ConvertKeyValueList(v interface{}) ([]irs.KeyValue, error) { | |||
| if cblogger.Level.String() == "debug" { | |||
There was a problem hiding this comment.
- cblogger.Debug() 함수 자체가 Log Level이 debug일 때만, 출력 되므로
- level check는 불필요한 부분입니다.
powerkimhub
reviewed
Jul 2, 2024
| @@ -199,7 +198,8 @@ func ExtractImageDescribeInfo(image *ecs.Image) irs.ImageInfo { | |||
| //*ecs.DescribeImagesResponse | |||
| if cblogger.Level.String() == "debug" { | |||
There was a problem hiding this comment.
cblogger.Debug() 함수 자체가 Log Level이 debug일 때만, 출력 되므로
level check는 불필요한 부분입니다.
powerkimhub
reviewed
Jul 2, 2024
| @@ -31,7 +30,7 @@ type AlibabaKeyPairHandler struct { | |||
| func (keyPairHandler *AlibabaKeyPairHandler) ListKey() ([]*irs.KeyPairInfo, error) { | |||
| cblogger.Debug("Start ListKey()") | |||
| var keyPairList []*irs.KeyPairInfo | |||
| //spew.Dump(keyPairHandler) | |||
| //cblogger.Debug(keyPairHandler) | |||
There was a problem hiding this comment.
- comment line과 동일한 code line이 중복 되는 부분이 많습니다.
- 자동 수정 과정에서 따라 들어간 것 같습니다.
- 전반적인 확인 부탁드립니다.
powerkimhub
reviewed
Jul 2, 2024
| @@ -134,7 +133,8 @@ func (securityHandler *AlibabaSecurityHandler) AddRules(securityIID irs.IID, req | |||
| cblogger.Infof("securityGroupId : [%s] / securityRuleInfos : [%v]", securityGroupId, reqSecurityRules) | |||
| //cblogger.Info("AuthorizeSecurityRules ", securityRuleInfos) | |||
| if cblogger.Level.String() == "debug" { | |||
There was a problem hiding this comment.
- cblogger.Debug() 함수 자체가 Log Level이 debug일 때만, 출력 되므로
- level check는 불필요한 부분입니다.
- 전반적인 확인 부탁 드립니다.
There was a problem hiding this comment.
cblogger.Debug() 함수 체크하여 보완했습니다.
powerkimhub
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed all spew.Dump() function (AWS)