Refactor drivers code #131

rsevilla87 · 2024-02-16T10:17:23Z

Type of change

Description

Refactoring drivers code, all drivers code has been moved to the drivers package, and they implement the new Driver interface. Resulting in a more intuitive and reduced code.

Now is also possible to select what driver to use, by default netperf is enabled, but it's possible to run the test with different combinations of drivers, i.e:

$ k8s-netperf --iperf # Will run the test using iperf and netperf

or

$ k8s-netperf --netperf=false --uperf # Will run the test using uperf

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

I have performed a self-review of my code.
If it is a core feature, I have added thorough tests.

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

Makefile

jtaleric

Need to dig into this failure a bit more

panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
main.executeWorkload({0x1, 0xa, {0xc00022d6f0, 0xa}, 0x3, 0x400, 0x0, {0x1ee68ee, 0x4}, 0x1}, ...)
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:358 +0xfc6
main.glob..func1(0xc000231900?, {0x1ee698e?, 0x4?, 0x1ee6992?})
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:187 +0x1065
github.com/spf13/cobra.(*Command).execute(0x3299a20, {0xc000132010, 0x1, 0x1})
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920 +0x863
github.com/spf13/cobra.(*Command).ExecuteC(0x3299a20)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x3a5
github.com/spf13/cobra.(*Command).Execute(...)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968
main.main()
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:464 +0x3c7
jtaleric at polaris in ~/code/k8s-netperf on interface-refactor△ $ git checkout main

I just ran w/ ./bin/amd64/k8s-netperf --debug

cmd/k8s-netperf/k8s-netperf.go

jtaleric · 2024-02-19T14:00:02Z

Need to dig into this failure a bit more

panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
main.executeWorkload({0x1, 0xa, {0xc00022d6f0, 0xa}, 0x3, 0x400, 0x0, {0x1ee68ee, 0x4}, 0x1}, ...)
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:358 +0xfc6
main.glob..func1(0xc000231900?, {0x1ee698e?, 0x4?, 0x1ee6992?})
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:187 +0x1065
github.com/spf13/cobra.(*Command).execute(0x3299a20, {0xc000132010, 0x1, 0x1})
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920 +0x863
github.com/spf13/cobra.(*Command).ExecuteC(0x3299a20)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x3a5
github.com/spf13/cobra.(*Command).Execute(...)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968
main.main()
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:464 +0x3c7
jtaleric at polaris in ~/code/k8s-netperf on interface-refactor△ $ git checkout main

I just ran w/ ./bin/amd64/k8s-netperf --debug

I patched the hostNet issues locally, but still running into issues :(

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x19fbb06]

goroutine 1 [running]:
main.executeWorkload({0x1, 0xa, {0xc00022d6f0, 0xa}, 0x3, 0x400, 0x0, {0x1ee68ee, 0x4}, 0x1}, ...)
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:398 +0x566
main.glob..func1(0xc000231900?, {0x1ee698e?, 0x4?, 0x1ee6992?})
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:187 +0x1065
github.com/spf13/cobra.(*Command).execute(0x3299a20, {0xc000132010, 0x1, 0x1})
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920 +0x863
github.com/spf13/cobra.(*Command).ExecuteC(0x3299a20)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x3a5
github.com/spf13/cobra.(*Command).Execute(...)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968
main.main()
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:464 +0x3c7

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

rsevilla87 · 2024-02-19T14:15:48Z

Need to dig into this failure a bit more

panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
main.executeWorkload({0x1, 0xa, {0xc00022d6f0, 0xa}, 0x3, 0x400, 0x0, {0x1ee68ee, 0x4}, 0x1}, ...)
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:358 +0xfc6
main.glob..func1(0xc000231900?, {0x1ee698e?, 0x4?, 0x1ee6992?})
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:187 +0x1065
github.com/spf13/cobra.(*Command).execute(0x3299a20, {0xc000132010, 0x1, 0x1})
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920 +0x863
github.com/spf13/cobra.(*Command).ExecuteC(0x3299a20)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x3a5
github.com/spf13/cobra.(*Command).Execute(...)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968
main.main()
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:464 +0x3c7
jtaleric at polaris in ~/code/k8s-netperf on interface-refactor△ $ git checkout main

I just ran w/ ./bin/amd64/k8s-netperf --debug

I patched the hostNet issues locally, but still running into issues :(

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x19fbb06]

goroutine 1 [running]:
main.executeWorkload({0x1, 0xa, {0xc00022d6f0, 0xa}, 0x3, 0x400, 0x0, {0x1ee68ee, 0x4}, 0x1}, ...)
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:398 +0x566
main.glob..func1(0xc000231900?, {0x1ee698e?, 0x4?, 0x1ee6992?})
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:187 +0x1065
github.com/spf13/cobra.(*Command).execute(0x3299a20, {0xc000132010, 0x1, 0x1})
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920 +0x863
github.com/spf13/cobra.(*Command).ExecuteC(0x3299a20)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x3a5
github.com/spf13/cobra.(*Command).Execute(...)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968
main.main()
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:464 +0x3c7

Need to dig into this failure a bit more

panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
main.executeWorkload({0x1, 0xa, {0xc00022d6f0, 0xa}, 0x3, 0x400, 0x0, {0x1ee68ee, 0x4}, 0x1}, ...)
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:358 +0xfc6
main.glob..func1(0xc000231900?, {0x1ee698e?, 0x4?, 0x1ee6992?})
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:187 +0x1065
github.com/spf13/cobra.(*Command).execute(0x3299a20, {0xc000132010, 0x1, 0x1})
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920 +0x863
github.com/spf13/cobra.(*Command).ExecuteC(0x3299a20)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x3a5
github.com/spf13/cobra.(*Command).Execute(...)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968
main.main()
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:464 +0x3c7
jtaleric at polaris in ~/code/k8s-netperf on interface-refactor△ $ git checkout main

I just ran w/ ./bin/amd64/k8s-netperf --debug

I patched the hostNet issues locally, but still running into issues :(

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x19fbb06]

goroutine 1 [running]:
main.executeWorkload({0x1, 0xa, {0xc00022d6f0, 0xa}, 0x3, 0x400, 0x0, {0x1ee68ee, 0x4}, 0x1}, ...)
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:398 +0x566
main.glob..func1(0xc000231900?, {0x1ee698e?, 0x4?, 0x1ee6992?})
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:187 +0x1065
github.com/spf13/cobra.(*Command).execute(0x3299a20, {0xc000132010, 0x1, 0x1})
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920 +0x863
github.com/spf13/cobra.(*Command).ExecuteC(0x3299a20)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x3a5
github.com/spf13/cobra.(*Command).Execute(...)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968
main.main()
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:464 +0x3c7

I can't reproduce it, what was the exact command you used?

jtaleric · 2024-02-19T16:11:39Z

I can't reproduce it, what was the exact command you used?

weird.

All I am doing is ./bin/amd64/k8s-netperf --debug

and I see

DEBU[2024-02-19 08:53:34] client-across Running on perf-fc640-4.perf.lab.eng.rdu2.redhat.com with IP 10.1.184.207 
DEBU[2024-02-19 08:53:34] Executing workloads. hostNetwork is false, service is false 
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x19fbb06]

goroutine 1 [running]:
main.executeWorkload({0x1, 0xa, {0xc00022d6f0, 0xa}, 0x3, 0x400, 0x0, {0x1ee68ee, 0x4}, 0x1}, ...)
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:398 +0x566
main.glob..func1(0xc000231900?, {0x1ee698e?, 0x4?, 0x1ee6992?})
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:187 +0x1065
github.com/spf13/cobra.(*Command).execute(0x3299a20, {0xc000132010, 0x1, 0x1})
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920 +0x863
github.com/spf13/cobra.(*Command).ExecuteC(0x3299a20)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x3a5
github.com/spf13/cobra.(*Command).Execute(...)
	/home/jtaleric/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968
main.main()
	/home/jtaleric/code/k8s-netperf/cmd/k8s-netperf/k8s-netperf.go:464 +0x3c7

Checking version

Version: interface-refactor
Git Commit: 9c61fac33db600342e36e9167e657aa240c2b8fd
Build Date: 2024-02-19-08:52:14
Go Version: go1.21.3
OS/Arch: linux amd64

jtaleric · 2024-02-19T16:46:33Z

k8s-netperf/cmd/k8s-netperf/k8s-netperf.go

Line 187 in 996f2d3

npr := executeWorkload(nc, s, true, false, false, false)

                                       npr := executeWorkload(nc, s, true, false, false, false)

this should be

                                       npr := executeWorkload(nc, s, false, false, false, false)

jtaleric · 2024-02-19T17:22:46Z

k8s-netperf/cmd/k8s-netperf/k8s-netperf.go

Line 187 in 996f2d3

npr := executeWorkload(nc, s, true, false, false, false)

                                       npr := executeWorkload(nc, s, true, false, false, false)

this should be

                                       npr := executeWorkload(nc, s, false, false, false, false)

Update...

The fields are.
executeWorkload(networkConfig, scenario, hostNetwork, netperfWorkload, iperfWorkload, uperfWorkload)

So, with this, the update to line -

k8s-netperf/cmd/k8s-netperf/k8s-netperf.go

Line 187 in 996f2d3

npr := executeWorkload(nc, s, true, false, false, false)

npr := executeWorkload(nc, s, false, true, false, false)

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

jtaleric · 2024-02-19T21:47:11Z

👀

rsevilla87 · 2024-02-20T12:27:40Z

👀

alright, it should be ready now

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

jtaleric

lgtm!

jtaleric · 2024-02-21T22:35:55Z

hm, just ran into this...

./bin/amd64/k8s-netperf
INFO[2024-02-21 17:30:28] 📒 Reading netperf.yml file.                  
INFO[2024-02-21 17:30:28] 📒 Reading netperf.yml file - using ConfigV2 Method.  
INFO[2024-02-21 17:30:28] Cleaning resources created by k8s-netperf    
INFO[2024-02-21 17:30:29] ⏰ Waiting for client-across Deployment to deleted... 
INFO[2024-02-21 17:31:00] ⏰ Waiting for server Deployment to deleted... 
INFO[2024-02-21 17:31:31] 🔬 prometheus discovered at openshift-monitoring 
WARN[2024-02-21 17:31:31] ⚠️  No zone label                            
WARN[2024-02-21 17:31:31] ⚠️  Single node per zone and/or no zone labels 
INFO[2024-02-21 17:31:31] 🚀 Creating service for iperf-service in namespace netperf 
INFO[2024-02-21 17:31:31] 🚀 Creating service for uperf-service in namespace netperf 
INFO[2024-02-21 17:31:31] 🚀 Creating service for netperf-service in namespace netperf 
INFO[2024-02-21 17:31:31] 🚀 Starting Deployment for: client-across in namespace: netperf 
INFO[2024-02-21 17:31:31] ⏰ Checking for client-across Pods to become ready... 
INFO[2024-02-21 17:31:34] 🚀 Starting Deployment for: server in namespace: netperf 
INFO[2024-02-21 17:31:34] ⏰ Checking for server Pods to become ready... 
INFO[2024-02-21 17:31:38] 🗒️  Running netperf TCP_STREAM (service false) for 10s  
INFO[2024-02-21 17:31:51] 🗒️  Running netperf TCP_STREAM (service false) for 10s  
INFO[2024-02-21 17:32:03] 🗒️  Running netperf TCP_STREAM (service false) for 10s  
FATA[2024-02-21 17:32:15] 😭 At least one driver needs to be enabled

We must need to set netperf to true by default.

jtaleric · 2024-02-21T22:39:17Z

https://github.com/cloud-bulldozer/k8s-netperf/pull/131/files#diff-2f4a29be1c0731286fb79f835c6fab35e1993e5d96990fc51e93953bfeeb8323R67

and i see we default it to true here - https://github.com/cloud-bulldozer/k8s-netperf/pull/131/files#diff-2f4a29be1c0731286fb79f835c6fab35e1993e5d96990fc51e93953bfeeb8323R431

I think this might be the Cobra bug wrt bools...

jtaleric · 2024-02-21T22:42:06Z

Nope, this is even weirder... we see it ran some tcp stream tests in the output i shared 😕

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

rsevilla87 · 2024-02-21T23:02:12Z

I can't reproduce it:

$ ./bin/amd64/k8s-netperf 
INFO[2024-02-21 23:56:41] 📒 Reading netperf.yml file.                  
INFO[2024-02-21 23:56:41] 📒 Reading netperf.yml file - using ConfigV2 Method.  
INFO[2024-02-21 23:56:41] Cleaning resources created by k8s-netperf    
INFO[2024-02-21 23:56:42] ⏰ Waiting for client-across Deployment to deleted... 
INFO[2024-02-21 23:56:54] ⏰ Waiting for server Deployment to deleted... 
INFO[2024-02-21 23:56:58] 🔬 prometheus discovered at openshift-monitoring 
WARN[2024-02-21 23:57:00] ⚠️   Single node per zone and/or no zone labels 
INFO[2024-02-21 23:57:01] 🚀 Creating service for iperf-service in namespace netperf 
INFO[2024-02-21 23:57:01] 🚀 Creating service for uperf-service in namespace netperf 
INFO[2024-02-21 23:57:02] 🚀 Creating service for netperf-service in namespace netperf 
INFO[2024-02-21 23:57:02] 🚀 Starting Deployment for: client-across in namespace: netperf 
INFO[2024-02-21 23:57:02] ⏰ Checking for client-across Pods to become ready... 
INFO[2024-02-21 23:57:05] 🚀 Starting Deployment for: server in namespace: netperf 
INFO[2024-02-21 23:57:05] ⏰ Checking for server Pods to become ready... 
INFO[2024-02-21 23:57:11] 🗒️   Running netperf TCP_STREAM (service false) for 10s  
INFO[2024-02-21 23:57:25] 🗒️   Running netperf TCP_STREAM (service false) for 10s  
INFO[2024-02-21 23:57:38] 🗒️   Running netperf TCP_STREAM (service false) for 10s  
INFO[2024-02-21 23:57:53] 🗒️   Running netperf TCP_STREAM (service false) for 10s  
INFO[2024-02-21 23:58:06] 🗒️   Running netperf TCP_STREAM (service false) for 10s  
INFO[2024-02-21 23:58:20] 🗒️   Running netperf TCP_STREAM (service false) for 10s  
INFO[2024-02-21 23:58:34] 🗒️   Running netperf UDP_STREAM (service false) for 10s  
INFO[2024-02-21 23:58:47] 🗒️   Running netperf UDP_STREAM (service false) for 10s  
INFO[2024-02-21 23:59:00] 🗒️   Running netperf UDP_STREAM (service false) for 10s  
INFO[2024-02-21 23:59:15] 🗒️   Running netperf TCP_CRR (service false) for 10s  
INFO[2024-02-21 23:59:30] 🗒️   Running netperf TCP_CRR (service false) for 10s  
INFO[2024-02-21 23:59:45] 🗒️   Running netperf TCP_CRR (service false) for 10s  
INFO[2024-02-22 00:00:01] 🗒️   Running netperf TCP_CRR (service true) for 10s  
INFO[2024-02-22 00:00:17] 🗒️   Running netperf TCP_CRR (service true) for 10s  
INFO[2024-02-22 00:00:32] 🗒️   Running netperf TCP_CRR (service true) for 10s  
INFO[2024-02-22 00:00:49] 🗒️   Running netperf TCP_RR (service false) for 10s  
INFO[2024-02-22 00:01:02] 🗒️   Running netperf TCP_RR (service false) for 10s  
INFO[2024-02-22 00:01:16] 🗒️   Running netperf TCP_RR (service false) for 10s  
blablabla
INFO[2024-02-22 00:01:38] Cleaning resources created by k8s-netperf    
INFO[2024-02-22 00:01:39] ⏰ Waiting for client-across Deployment to deleted... 
INFO[2024-02-22 00:02:10] ⏰ Waiting for server Deployment to deleted...

rsevilla87 changed the title ~~Refactor drivers code~~ WIP: Refactor drivers code Feb 16, 2024

Refactor drivers code

8676851

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

rsevilla87 force-pushed the interface-refactor branch from 9d1bc90 to 8676851 Compare February 16, 2024 11:27

rsevilla87 requested review from jtaleric and venkataanil February 16, 2024 11:28

rsevilla87 changed the title ~~WIP: Refactor drivers code~~ Refactor drivers code Feb 16, 2024

Update docs

9c61fac

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

rsevilla87 added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 16, 2024

rsevilla87 commented Feb 19, 2024

View reviewed changes

Makefile Show resolved Hide resolved

jtaleric reviewed Feb 19, 2024

View reviewed changes

cmd/k8s-netperf/k8s-netperf.go Outdated Show resolved Hide resolved

cmd/k8s-netperf/k8s-netperf.go Outdated Show resolved Hide resolved

Fix hostnet arguments

996f2d3

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

rsevilla87 added 2 commits February 19, 2024 21:42

Fixing netperf flags

36a00d3

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

Fix hostNetwork code

85213fd

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

rsevilla87 added 2 commits February 20, 2024 13:30

Remove binary from clean target

1eb0db4

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

Require one driver at least

adb6cad

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

rsevilla87 force-pushed the interface-refactor branch from 2984860 to adb6cad Compare February 21, 2024 20:16

jtaleric approved these changes Feb 21, 2024

View reviewed changes

jtaleric self-requested a review February 21, 2024 22:35

Inform about k8s-netperf version

534120b

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

jtaleric merged commit c99337e into cloud-bulldozer:main Feb 22, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor drivers code #131

Refactor drivers code #131

rsevilla87 commented Feb 16, 2024 •

edited

Loading

jtaleric left a comment

jtaleric commented Feb 19, 2024

rsevilla87 commented Feb 19, 2024

jtaleric commented Feb 19, 2024

jtaleric commented Feb 19, 2024

jtaleric commented Feb 19, 2024

jtaleric commented Feb 19, 2024

rsevilla87 commented Feb 20, 2024

jtaleric left a comment

jtaleric commented Feb 21, 2024

jtaleric commented Feb 21, 2024

jtaleric commented Feb 21, 2024

rsevilla87 commented Feb 21, 2024 •

edited

Loading

Refactor drivers code #131

Refactor drivers code #131

Conversation

rsevilla87 commented Feb 16, 2024 • edited Loading

Type of change

Description

Related Tickets & Documents

Checklist before requesting a review

jtaleric left a comment

Choose a reason for hiding this comment

jtaleric commented Feb 19, 2024

rsevilla87 commented Feb 19, 2024

jtaleric commented Feb 19, 2024

jtaleric commented Feb 19, 2024

jtaleric commented Feb 19, 2024

jtaleric commented Feb 19, 2024

rsevilla87 commented Feb 20, 2024

jtaleric left a comment

Choose a reason for hiding this comment

jtaleric commented Feb 21, 2024

jtaleric commented Feb 21, 2024

jtaleric commented Feb 21, 2024

rsevilla87 commented Feb 21, 2024 • edited Loading

rsevilla87 commented Feb 16, 2024 •

edited

Loading

rsevilla87 commented Feb 21, 2024 •

edited

Loading