Fix unexpected parameter when query schema is empty object

cloudflare · Mar 13, 2024 · b25775c · b25775c
1 parent 6c8d721
commit b25775c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/openapi.ts b/src/openapi.ts
@@ -44,8 +44,8 @@ export function OpenAPIRouter<
   RequestType = IRequest,
   Args extends any[] = any[],
   RouteType = Equal<RequestType, IRequest> extends true
-  ? Route
-  : UniversalRoute<RequestType, Args>
+    ? Route
+    : UniversalRoute<RequestType, Args>
 >(options?: RouterOptions): OpenAPIRouterType<RouteType, Args> {
   const registry: OpenAPIRegistryMerger = new OpenAPIRegistryMerger()
 

diff --git a/src/parameters.ts b/src/parameters.ts
@@ -300,7 +300,13 @@ export function extractQueryParameters(
 ): Record<string, any> | null {
   const { searchParams } = new URL(request.url)
 
-  if (searchParams.size === 0) {
+  // For older node versions, searchParams is just an object without the size property
+  if (
+    searchParams.size === 0 ||
+    (searchParams.size === undefined &&
+      typeof searchParams === 'object' &&
+      Object.keys(searchParams).length === 0)
+  ) {
     return null
   }