Start work on the WorkersKV API so we can write and read info from the KV system #139
Conversation
Fix CS issues for WorkerKV class and test
| @@ -0,0 +1,22 @@ | |||
| { | |||
There was a problem hiding this comment.
looks like this file should have been ignored from the gitignore above. can we remove it?
| @@ -1,3002 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
did you forget to commit these changes? looks like the entire file has been deleted and not updated.
| /** | ||
| * User: junade | ||
| * Date: 01/02/2017 | ||
| * Time: 12:30 | ||
| */ | ||
|
|
There was a problem hiding this comment.
| /** | |
| * User: junade | |
| * Date: 01/02/2017 | |
| * Time: 12:30 | |
| */ |
| public function writeMultipleKeyValuePairs(string $accountID, $namespaceIdentifier, $keys = []): bool | ||
| { | ||
| $this->adapter->put('accounts/' . $accountID . '/storage/kv/namespaces/' . $namespaceIdentifier . '/bulk', $keys); | ||
| return true; |
There was a problem hiding this comment.
do we want to handle the exception here if the PUT request fails? i.e. additional logging, output, etc?
| $this->assertEquals("Some Value", $result); | ||
| } | ||
|
|
||
| public function testDeleteKeyValuePair () |
There was a problem hiding this comment.
| public function testDeleteKeyValuePair () | |
| public function testDeleteKeyValuePair() |
| public function getReadKeyValuePair(string $accountID, $namespaceIdentifier, $keyName): string | ||
| { | ||
| $response = $this->adapter->get('accounts/' . $accountID . '/storage/kv/namespaces/' . $namespaceIdentifier . '/values/' . $keyName); | ||
| $this->body = json_decode($response->getBody()); |
There was a problem hiding this comment.
My understanding is that the Content-Type for these responses is application/octet-stream, so we shouldn't be json_decode-ing here. Since the type returned by $response->getBody(), StreamInterface, supports __toString() and seems to do the right thing, it might be worth changing this to:
- $this->body = json_decode($response->getBody());
+ $this->body = (string) $response->getBody();
|
If someone is not taking the action to fix the changes request I'll fork it by myself and submit the PR as it should be 😂 |
|
|
||
| public function deleteKeyValuePair(string $accountID, $namespaceIdentifier, string $key): bool | ||
| { | ||
| $this->adapter->delete('accounts/' . $accountID . '/storage/kv/namespaces/' . $namespaceIdentifier . '/values', [$key]); |
There was a problem hiding this comment.
I've just had to use this method and it looks like this might be an old way of deleting the KV pair as it is now throwing a 404 error.
According to the documentation the key should be part of the url instead of the body:
https://api.cloudflare.com/#workers-kv-namespace-delete-key-value-pair
| $this->adapter->delete('accounts/' . $accountID . '/storage/kv/namespaces/' . $namespaceIdentifier . '/values', [$key]); | |
| $this->adapter->delete('accounts/' . $accountID . '/storage/kv/namespaces/' . $namespaceIdentifier . '/values/' . $key); |
|
Any plans to finish this? |
|
is this repo fully community driven or CF employees here to help? KV support is needed badly! |
|
Sorry just noticed the comments :( lost track of the project since the client did not need it. |
This is work to start making this part of the PHP library.
Not all the API endpoints are there. I will add more shortly.