fix: let "assets" in wrangler.toml be a string #5938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e51e0b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9291853086/npm-package-wrangler-5938You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5938/npm-package-wrangler-5938Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9291853086/npm-package-wrangler-5938 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9291853086/npm-package-create-cloudflare-5938 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9291853086/npm-package-cloudflare-kv-asset-handler-5938npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9291853086/npm-package-miniflare-5938npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9291853086/npm-package-cloudflare-pages-shared-5938npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9291853086/npm-package-cloudflare-vitest-pool-workers-5938Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
The experimental "assets" field can be either a string or an object. However the type definition marks it only as an object. This is a problem because we use this to generate the json schema, which gets picked up by vscode's even better toml extension, and shows it to be an error when used with a string (even though it works fine). The fix is to simply change the type definition to add a string variant.
threepointone
force-pushed
the
fix-assets-config-type
branch
from
67f96ec
to
e51e0b6
Compare
CarmenPopoviciu
approved these changes
May 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experimental "assets" field can be either a string or an object. However the type definition marks it only as an object. This is a problem because we use this to generate the json schema, which gets picked up by vscode's even better toml extension, and shows it to be an error when used with a string (even though it works fine). The fix is to simply change the type definition to add a string variant.