Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws_iam_role): add permission_boundary to aws_iam_role #108

Merged
merged 11 commits into from
Mar 14, 2021
Merged

feat(aws_iam_role): add permission_boundary to aws_iam_role #108

merged 11 commits into from
Mar 14, 2021

Conversation

ib-ak
Copy link

@ib-ak ib-ak commented Mar 11, 2021 •
edited
Loading

what

  • added permission_boundary input to aws_iam_role
  • created a variable
  • updated readme

why

  • adding permission boundary to IAM Role

references

@ib-ak ib-ak requested review from a team as code owners March 11, 2021 21:34
@ib-ak ib-ak changed the title feat(107): add permission_boundary to aws_iam_role feat(aws_iam_role): add permission_boundary to aws_iam_role Mar 11, 2021
Gowiem
Gowiem previously approved these changes Mar 13, 2021
View reviewed changes
@Gowiem
Copy link
Member

Gowiem commented Mar 13, 2021

/test all

@Gowiem
Copy link
Member

Gowiem commented Mar 13, 2021

@abhinavkhanna-sf looks like you named the argument incorrectly: permission_boundary should be permissions_boundary. Can you update both the argument name and the variable name?

TestExamplesComplete 2021-03-13T17:21:52Z command.go:121:   20:   permission_boundary = var.permission_boundary
TestExamplesComplete 2021-03-13T17:21:52Z command.go:121: 
TestExamplesComplete 2021-03-13T17:21:52Z command.go:121: An argument named "permission_boundary" is not expected here. Did you mean
TestExamplesComplete 2021-03-13T17:21:52Z command.go:121: "permissions_boundary"?

Abhinav Khanna and others added 2 commits March 13, 2021 16:47
@ib-ak
Copy link
Author

ib-ak commented Mar 13, 2021

@Gowiem fixed.

@Gowiem
Copy link
Member

Gowiem commented Mar 13, 2021

/test all

@Gowiem Gowiem merged commit 68be560 into cloudposse:master Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@jhosteny jhosteny Awaiting requested review from jhosteny

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add permissions_boundary variable to aws_iam_role
3 participants
@ib-ak @Gowiem @cloudpossebot