OIDC thumbprint_list can be retrieved and tags added to OIDC provider #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 31, 2021 02:40
- With hashicorp/terraform-provider-tls#62 sha1_fingerprint can be retrieved instead of hardcoding it (which isn't safe as not all regions have the same)
|
/rebuild-readme |
|
/test all |
aknysh
reviewed
May 31, 2021
main.tf
Outdated
| @@ -84,13 +84,17 @@ resource "aws_eks_cluster" "default" { | |||
| # https://docs.aws.amazon.com/eks/latest/userguide/enable-iam-roles-for-service-accounts.html | |||
| # https://medium.com/@marcincuber/amazon-eks-with-oidc-provider-iam-roles-for-kubernetes-services-accounts-59015d15cb0c | |||
| # | |||
|
|
|||
| data "tls_certificate" "cluster" { | |||
| url = join("", aws_eks_cluster.default.*.identity.0.oidc.0.issuer) | |||
There was a problem hiding this comment.
please add
count = (local.enabled && var.oidc_provider_enabled) ? 1 : 0
so if the module is disabled, the data sources won't be read
aknysh
reviewed
May 31, 2021
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
|
Hi @aknysh , I've added the |
|
/test all |
nitrocode
approved these changes
Jun 4, 2021
aknysh
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what/why
sha1_fingerprintcan be set automatically instead of be hardcoded, which is prone to error since some region has a different one.module.label.tagsreferences