Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better behavior during destroy #169

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Better behavior during destroy #169

merged 2 commits into from
Oct 17, 2022

Conversation

Nuru
Copy link
Sponsor Contributor

@Nuru Nuru commented Oct 17, 2022

what

  • Improve behavior during terraform destroy
  • Update documentation

why

  • Clusters should destroy cleanly, but previously did not
  • Documentation referred to old examples, wrong security group

references

@Nuru Nuru added bugfix Change that restores intended behavior minor New features that do not break anything labels Oct 17, 2022
@Nuru Nuru requested review from a team as code owners October 17, 2022 21:51
@Nuru Nuru enabled auto-merge (squash) October 17, 2022 21:53
@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Oct 17, 2022

/test all

@Nuru Nuru merged commit 1c44f2c into master Oct 17, 2022
@Nuru Nuru deleted the destroy branch October 17, 2022 22:20
@Nuru Nuru mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benbentwo Benbentwo Benbentwo approved these changes

@aknysh aknysh Awaiting requested review from aknysh

@nitrocode nitrocode Awaiting requested review from nitrocode

@milldr milldr Awaiting requested review from milldr

@dylanbannon dylanbannon Awaiting requested review from dylanbannon

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher was automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
bugfix Change that restores intended behavior minor New features that do not break anything
Projects
None yet
Milestone
No milestone
3 participants
@Nuru @Benbentwo @cloudpossebot