Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Add dates in cEPs metadata #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bharatpurohit97
Copy link
Member

@bharatpurohit97 bharatpurohit97 commented Nov 25, 2018

This add date field to cEPs metadata in README.md

Closes #61

@bharatpurohit97
Copy link
Member Author

@li-boxuan review requested.

@bharatpurohit97 bharatpurohit97 force-pushed the issue#61+patch#61+gh#61+includedates branch from 322f287 to a09f0a6 Compare November 25, 2018 19:09
Copy link
Member

@li-boxuan li-boxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need more reviews and thoughts to see how we should deal with #61

README.md Outdated
| [cEP-0022](cEP-0022.md) | coala-quickstart Green Mode | This cEP provides the features, needs, requirements and implementation of the green-mode being added to coala-quickstart. |
| [cEP-0025](cEP-0025.md) | Integrate pyflakes AST into coala | This cEP describes the details of the process of integrating the pyflakes-enhanced-AST into coala as part of [GSoC'18 project](https://summerofcode.withgoogle.com/projects/#5549789140221952). |
| [cEP-0027](cEP-0027.md) | coala Bears Testing API | This cEP describes the implementation process of `BaseTestHelper` class and `GlobalBearTestHelper` class to improve testing API of coala as a part of the [GSoC'18 project](https://summerofcode.withgoogle.com/projects/#6625036551585792). |
| Filename | Title | Date | Description |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name Date here is ambiguous. What date? Creation date? Last update date?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Date refers Creation dates.

Copy link
Member Author

@bharatpurohit97 bharatpurohit97 Dec 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. please review latest commit @li-boxuan

@bharatpurohit97 bharatpurohit97 force-pushed the issue#61+patch#61+gh#61+includedates branch 2 times, most recently from b891659 to ff0f7c0 Compare December 7, 2018 18:11
This add date of creation to cEPs metadata in README.md

Closes coala#61
@bharatpurohit97 bharatpurohit97 force-pushed the issue#61+patch#61+gh#61+includedates branch from ff0f7c0 to 92f60ae Compare December 7, 2018 18:23
@bharatpurohit97
Copy link
Member Author

@jayvdb @li-boxuan please review.

@bharatpurohit97
Copy link
Member Author

@Mariatta please review.

Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@Mariatta Mariatta dismissed li-boxuan’s stale review February 16, 2019 20:38

The requested change has been implemented

@Mariatta
Copy link
Member

ack 92f60ae

@Mariatta
Copy link
Member

Since @li-boxuan is code owner, the review is required from them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants