release-24.2.1-rc: security,jwtauthccl: Fix test failures due to leaked goroutines #129934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #129802 on behalf of @pritesh-lahoti.
/cc @cockroachdb/release
We have been seeing intermittent test failures for
TestUseCerts
andTestJWTAuthWithCustomCACert
.These failures have been due to a leaked goroutine that establishes a TLS handshake.
The change is to ignore this goroutine while checking for leaked goroutines.
Added a TODO to revisit this once we update Go to 1.23, as this seems to
have been fixed: golang/go#62227.
Epic: CRDB-36214
Fixes: #119052, #128214, #129073
Release note: None
Release justification: Fix test failure flagged as release blocker in #129073