kvserver,rac2,replica_rac2: consistently read from RawNode #132049
+148
−428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replica_rac2.RaftNode interface is no more, and is replaced by RaftNodeBasicState that is passed in to Processor by the caller. The rac2.RaftInterface remains, and is solely for use by RangeController. Various methods on replica_rac2.Replica are also removed. kvserver.Replica is responsible for populating RaftNodeBasicState and RaftEvent.ReplicasStateInfo (the latter was previously being populated in processorImpl). For the raft state accessed by RAC2 code during Replica.handleRaftReady, this centralizes all Raft state access to when Replica.handleRaftReadyRaftMuLocked locks the Replica.mu. Epic: CRDB-37515 Release note: None
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replica_rac2.RaftNode interface is no more, and is replaced by RaftNodeBasicState that is passed in to Processor by the caller.
The rac2.RaftInterface remains, and is solely for use by RangeController. Various methods on replica_rac2.Replica are also removed.
kvserver.Replica is responsible for populating RaftNodeBasicState and RaftEvent.ReplicasStateInfo (the latter was previously being populated in processorImpl).
For the raft state accessed by RAC2 code during Replica.handleRaftReady, this centralizes all Raft state access to when
Replica.handleRaftReadyRaftMuLocked locks the Replica.mu.
Epic: CRDB-37515
Release note: None