-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some warnings #3051
Fix some warnings #3051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for cleaning the code base! I commented some lines. Some changes seem to be not right. If a test case says it's testing some target, then we should ensure it's calling that target, even if it is deprecated.
contrib/scoverage/api/src/mill/contrib/scoverage/api/ScoverageReportWorkerApi.scala
Outdated
Show resolved
Hide resolved
a381e13
to
58aea28
Compare
I addressed your comments and rebased on the latest |
@lefou I guess the tests failing on some platforms are unrelated to my changes? |
I think this test error is not unrelated.
|
main/codesig/test/cases/callgraph/realistic/3-par-merge-sort/src/Hello.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I'm not sure if some of those warnings were intentional.
If so, please let me know and I'll take them out of the PR.