Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some warnings #3051

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Fix some warnings #3051

merged 2 commits into from
Mar 6, 2024

Conversation

nightscape
Copy link
Contributor

I'm not sure if some of those warnings were intentional.
If so, please let me know and I'll take them out of the PR.

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning the code base! I commented some lines. Some changes seem to be not right. If a test case says it's testing some target, then we should ensure it's calling that target, even if it is deprecated.

@nightscape nightscape force-pushed the fix-warnings branch 2 times, most recently from a381e13 to 58aea28 Compare February 29, 2024 12:28
@nightscape
Copy link
Contributor Author

I addressed your comments and rebased on the latest main.
Let's see what the tests say 😉

@nightscape
Copy link
Contributor Author

@lefou I guess the tests failing on some platforms are unrelated to my changes?
If so, this would be good to merge from my side 😃

@lefou
Copy link
Member

lefou commented Mar 6, 2024

I think this test error is not unrelated.

 X mill.codesig.CallGraphTests.realistic.3-par-merge-sort 38ms 
  ujson.ParseException: expected whitespace or eof got "*" at index 2817
    ujson.CharParser.die(CharParser.scala:98)
    ujson.CharParser.parse(CharParser.scala:77)
    ujson.StringParser$.transform(StringParser.scala:28)
    ujson.StringParser$.transform(StringParser.scala:27)
    ujson.Readable$fromTransformer.transform(Readable.scala:19)
    upickle.Api.$anonfun$read$1(Api.scala:42)
    upickle.core.TraceVisitor$.withTrace(TraceVisitor.scala:18)
    upickle.Api.read(Api.scala:42)
    upickle.Api.read$(Api.scala:41)
    upickle.default$.read(Api.scala:238)
    mill.codesig.CallGraphTests$.$anonfun$parseJson$8(CallGraphTests.scala:191)
    scala.Option.map(Option.scala:242)
    mill.codesig.CallGraphTests$.parseJson(CallGraphTests.scala:191)
    mill.codesig.CallGraphTests$.testDirectCallGraph(CallGraphTests.scala:112)
    mill.codesig.CallGraphTests$.testExpectedCallGraph(CallGraphTests.scala:97)
    mill.codesig.CallGraphTests$.$anonfun$tests$59(CallGraphTests.scala:13)

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lefou lefou merged commit 384d757 into com-lihaoyi:main Mar 6, 2024
38 checks passed
@lefou lefou added this to the 0.11.8 milestone Mar 6, 2024
@nightscape nightscape deleted the fix-warnings branch March 6, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants