Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSP: Handle new JvmCompileClasspath request #3086

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Conversation

lefou
Copy link
Member

@lefou lefou commented Mar 17, 2024

Implemented the new JmvCompileClasspath request as part of the JVM extension.

If the client reports to support the JvmCompileClasspathReceiver capability,
we also return an empty classpath from the ScalacOptions request.

Update bsp4j from 2.2.0-M1 to 2.2.0-M2

See:

If the client report to support the `JvmCompileClasspathReceiver` capability,
we also return an empty classpath from the `ScalacOptions` request.

Update bsp4j from 2.2.0-M1 to 2.2.0-M2
@lefou lefou changed the title Handle new JvmCompileClasspath request BSP: Handle new JvmCompileClasspath request Mar 17, 2024
@lefou lefou merged commit 28e41ab into main Mar 17, 2024
35 of 36 checks passed
@lefou lefou deleted the update-bsp4j-2.2.0-M2 branch March 17, 2024 20:15
@lefou lefou added this to the 0.11.8 milestone Mar 17, 2024
kasiaMarek added a commit to kasiaMarek/metals that referenced this pull request Jun 26, 2024
kasiaMarek added a commit to kasiaMarek/metals that referenced this pull request Jun 27, 2024
kasiaMarek added a commit to scalameta/metals that referenced this pull request Jun 28, 2024
* improvement: add debug adapter for running main class to metals

* add tests

* wee cleanup

* clean up

* fix: use javacOptions classpath if scalacOptions are empty

connected to: com-lihaoyi/mill#3086

* add more informative errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant