Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support build.sc in Bloop #3208

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Support build.sc in Bloop #3208

merged 7 commits into from
Jun 18, 2024

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Jun 14, 2024

After Mill 0.11 mill-contrib-bloop stopped supporting the build module.
Now BloopImpl gets a sequence of Evaluators and gets all modules for all the evaluators in Evaluator.allBootstrapEvaluators, so it supports the build module again.

Pull Request: #3208

@lolgab lolgab marked this pull request as ready for review June 14, 2024 20:05
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to seem some test coverage for a meta-build support.

@lolgab lolgab requested a review from lefou June 17, 2024 19:47
@lolgab lolgab added the contrib Issues related to contrib modules, which are probably maintained by someone outside mill core team label Jun 17, 2024
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added test isn't really using a meta-build.

@lolgab
Copy link
Member Author

lolgab commented Jun 17, 2024

You are right! I was confusing the normal mill build with the meta-build.
After Mill 0.11 mill-contrib-bloop stopped supporting the build module.
This gets all modules for all the evaluators, so it supports the build module again.
Maybe I should change the PR description since what I did is not specific to meta builds.
What do you think?

@lolgab lolgab changed the title Support meta-build in Bloop Support build.sc in Bloop Jun 17, 2024
@lolgab lolgab requested a review from lefou June 17, 2024 21:32
@lefou
Copy link
Member

lefou commented Jun 18, 2024

You are right! I was confusing the normal mill build with the meta-build. After Mill 0.11 mill-contrib-bloop stopped supporting the build module. This gets all modules for all the evaluators, so it supports the build module again. Maybe I should change the PR description since what I did is not specific to meta builds. What do you think?

Yeah, makes sense. If you can move this message into a PR description, we should be good to merge it.

I assume full support for meta-builds should be around the corner, just by the fact that the bootstrap build works. What's needed for confidence is a test case with a meta-build. But this can be another PR.

@lefou lefou added this to the 0.11.8 milestone Jun 18, 2024
@lolgab lolgab merged commit d7e471e into com-lihaoyi:main Jun 18, 2024
39 checks passed
@lolgab lolgab deleted the bloop-meta-build branch June 18, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contrib Issues related to contrib modules, which are probably maintained by someone outside mill core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants