Use shorter partially-qualified names when labelling named tasks during planning #3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than
foo.super.bar.qux.Baz.foo, we now usefoo.super.Baz. If there are multipleBazclasses with the same task being overriden (probably rare), we use the longest partially-qualified path suffix that's able to uniquely distinguish them. We also always drop the right-most path segment, since all that does is repeat the task name we already have on the leftAlso tweaked the
visualizetasks to use the same planning/labelling logic as the evaluator, so the labels we see in the SVG are the same labels seen in the terminalAdjusted existing tests, and added additional tests to cover the partially-qualified-name selection