Fix some doc typos + slight doc proposal on java integration test section #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
reviewed
Sep 15, 2024
| @@ -57,7 +57,7 @@ trait MicronautModule extends MavenModule{ | |||
| // Although Mill does not have a built in `MicronautModule`, this example shows how easy | |||
| // it is to define it yourself as `trait MicronautModule`: setting up the annotation processor | |||
| // classpath as a `JavaModule` and setting up the annotation via `javacOptions`. Once defined, | |||
| // you can then use `MicronautModule in your build just like you. | |||
| // you can then use `MicronautModule` in your build just like you. | |||
There was a problem hiding this comment.
Is something missing at the end of this sentence? "just like you ..." What?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some doc typos in the Java section,
I also rephrased a section on java integration test, emphasizing more on the mill way to do it rather than the usage of Junit5/4, i can drop the commit if it is not suited