Provided dummy def millDiscover and implicit RootModule.Info to make IDEs not display errors
#3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntelliJ/VSCode can't see the generated code so they think that these things are missing, but they're not. Rather than changing IntelliJ/VSCode, for now we just provide dummy definitions that get overriden by the codegen but are enough to make the IDEs happy
Before, we see errors in
extends RootModulebecause of the missing implicitRootModule.Info, and errors on theobjectas a whole because of the missingdef millDiscover:After, those two errors are gone, although the "need override keyword" errors remain:
Eventually we may have dedicated IDE support, but for now this hacks around one of the more visible IDE issues