Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -sourceroot flag when generating semanticdb with scala 3 #3595

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

bishabosha
Copy link
Contributor

while developing Scala 3 port, when using metals as the BSP server then semanticdb files are generated in the same folder as the source file.

With this change, and setting the bootstrapped mill version for BSP server, metals no longer puts semanticdb in the same directory, but instead in out/../semanticdbData.dest/classes/META-INF/semanticdb/...

without this, when using metals as the BSP server then semanticdb files are generated in the same folder as the source file.
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I remember vaguely, that when implementing it initially, someone said the sourceroot is supposed to determined automatically. But I like the explicit setup.

@lihaoyi lihaoyi merged commit 89bce51 into com-lihaoyi:main Sep 24, 2024
24 checks passed
@lefou lefou added this to the 0.12.0-RC3 milestone Sep 24, 2024
@bishabosha bishabosha deleted the patch-1 branch September 24, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants