Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused env var in examples forkEnv #3602

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Remove unused env var in examples forkEnv #3602

merged 1 commit into from
Sep 26, 2024

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Sep 25, 2024 •
edited
Loading

Stumbled upon it when diving in the examples internals. It seems to me that this env var is unused (can't find it anywhere else by grepping the whole codebase).

lihaoyi
lihaoyi approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@lihaoyi lihaoyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, may be a relic of an older version of the example test suites before #3398 extracted them out into a self contained class

@lihaoyi lihaoyi marked this pull request as ready for review September 26, 2024 01:09
@lihaoyi lihaoyi merged commit fd46d8e into com-lihaoyi:main Sep 26, 2024
24 checks passed
@lefou lefou added this to the 0.12.0-RC3 milestone Sep 26, 2024
@alexarchambault alexarchambault deleted the unused-env-var branch September 26, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihaoyi lihaoyi lihaoyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0-RC3
Development

Successfully merging this pull request may close these issues.
3 participants
@alexarchambault @lihaoyi @lefou