Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove T.log.withPromptPaused in favor of disabling the prompt automatically for every exclusive command #3634

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Oct 1, 2024

We continue printing the ticker task-output header above the output for every task, so if you run more than one exclusive command like resolve _ + version you can see which block of output belongs to which command

[1/2] resolve
clean
init
inspect
path
plan
resolve
show
showNamed
shutdown
taskSpawningFutures
version
visualize
visualizePlan
[2/2] version
0.12.0-RC2-63-2851b8-DIRTYc324c032

As a result of re-using PrefixLogger and PrefixOutputStream, exclusive command output continues to be line-buffered, and cannot display sub-line terminal UIs such as loading bars. That could potentially be fixed in future

Tested manually via ./mill -i dist.launcher && (cd example/depth/tasks/7-forking-futures && ../../../../out/dist/launcher.dest/run -w resolve _ + version)

@lihaoyi lihaoyi marked this pull request as ready for review October 1, 2024 01:02
@lihaoyi lihaoyi merged commit 23b0be1 into com-lihaoyi:main Oct 1, 2024
24 checks passed
@lefou lefou added this to the 0.12.0-RC3 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants