Speed up hangul composition #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I earlier commented in #33 about tests not working. It seems the tests are there but they are based on first few hangul characters and for those cases the incorrect code worked fine. |
|
Added a new commit for better speed up, results (% diff) before and after the new commit: To compare just hangul: We are now better than text-icu in all cases except mixed chars and Japanese. |
|
Could you possibly rebase this atop of #39? To estimate the effect of lookahead on its own, once divisions are as fast as possible. |
|
I rebased this branch locally atop of master. It still provides a decent improvement. |
Earlier were determining the type of the hangul syllable as soon as we saw it. Determining whether it is a hangul LV or not required a division operation which is expensive. Instead we now delay this decision until we see the next character. In most cases we do not need to determine this, we only need to determine it if the syllable is LV and it is followed by a T. With this we need very little division, therefore speeding up hangul composition significantly.
harendra-kumar
force-pushed
the
compose-hangul
branch
from
7c4c3ea
to
2f70dc9
Compare
|
Rebased, this is what I see: |
|
Comparison with text-icu: AllChars and Japanese are the only ones where we are significantly worse than text-icu: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use faster divisibility-by-28 check.
Perf comparison: