Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass abort signal to transport for mutations #351

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

paul-sachs
Copy link
Collaborator

@paul-sachs paul-sachs commented Mar 1, 2024

Need to propagate the abort signal from callOptions into the underlying transport.

@paul-sachs
Copy link
Collaborator Author

@timostamm Most of the changes are just due to adding a getCount method to our stateful count service example, otherwise just a two line change to use-mutation.ts

Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paul-sachs paul-sachs merged commit 103a094 into main Mar 1, 2024
5 checks passed
@paul-sachs paul-sachs deleted the psachs/mutation-signal branch March 1, 2024 20:48
@paul-sachs paul-sachs mentioned this pull request Mar 1, 2024
paul-sachs added a commit that referenced this pull request Mar 1, 2024
## What's Changed
* Pass abort signal to transport for mutations by @paul-sachs in
#351


**Full Changelog**:
v1.3.0...v1.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants