Regenerate with protoc-gen-go 1.3.5 #572
Conversation
Use CSI spec from container-storage-interface/spec#572 to test the provisioner with a fixed CSI structures.
There was a problem hiding this comment.
Should run go mod tidy to move github.com/golang/protobuf to direct dep.
Sorry for the inconvenience of introducing breaking changes. Could you suggest an alternative way to release the upgrade in the future? Maybe split the golang generated code to another repo (or place the go.mod in lib/go subdirectory), and only release v0 for the new module. If someone want old version of protoc-gen-go, he can always generate his own structs.
| @@ -46,8 +46,6 @@ PROTOC_URL := https://github.com/protocolbuffers/protobuf/releases/download/v$(P | |||
| PROTOC_TMP_DIR := .protoc | |||
| PROTOC := $(PROTOC_TMP_DIR)/bin/protoc | |||
|
|
|||
| $(GOBIN)/protoc-gen-go: ../../go.mod | |||
| go install google.golang.org/protobuf/cmd/protoc-gen-go | |||
There was a problem hiding this comment.
Why not just change this line to
go install github.com/golang/protobuf/protoc-gen-go@v1.3.5
So we don't need any other changes to the Makefile
There was a problem hiding this comment.
This did not work for me, it wanted to downgrade other packages in go.mod
There was a problem hiding this comment.
That's strange. I tried this and it works for me. github.com/golang/protobuf stays at v1.5.3 in go.mod
There was a problem hiding this comment.
Your're right, I was installing google.golang.org/protobuf/cmd/protoc-gen-go@v1.3.5 and not github.com/golang/protobuf/protoc-gen-go@v1.3.5.
I updated the PR, now it's a super simple PR.
|
Also note this PR does not revert the breaking change of requiring embedding |
jsafrane
force-pushed
the
revert-gen-go
branch
from
596cbbd
to
a319f1c
Compare
go.mod has github.com/golang/protobuf 1.5.3, which has a protoc-gen-go that is not compatible with csi.pb.go in this repo. Download github.com/golang/protobuf v1.3.5 separately, build protoc-gen-go from it and use it to generate csi.pb.go. The code is copied from the previous release of CSI spec, only with minor changes. A future update to 1.5.3 must be done carefuly and announce a breaking change.
jsafrane
force-pushed
the
revert-gen-go
branch
from
a319f1c
to
a79e25c
Compare
Regenerated csi.pb.go with older protoc-gen-go to restore grpc message structures.
go.mod has github.com/golang/protobuf 1.5.3, which has a protoc-gen-go that generates code that introduces breaking changes, see #570.
Instead of 1.5.3, download github.com/golang/protobuf v1.3.2 separately, build protoc-gen-go from it and use it to generate csi.pb.go. The code is copied from the previous release of CSI spec, only with minor changes.
A future update to 1.5.3 must be done carefully and announce a breaking change.
Which issue(s) this PR fixes:
Fixes #570
Does this PR introduce an API-breaking change?: