core: add methods to configure macvlan interface for container and point to latest rtnetlink
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya Rajan <arajan@redhat.com>
flouthoc
changed the title
macvlan interface for container and point to laster rtnetlinkmacvlan interface for container and point to latest rtnetlink
flouthoc
commented
Nov 12, 2021
| tokio::spawn(_connection); | ||
|
|
||
| //generate a random name on host to prevent collision. | ||
| //check https://github.com/containernetworking/plugins/blob/master/plugins/main/macvlan/macvlan.go#L176 |
There was a problem hiding this comment.
This is important for our use-case to work.
Luap99
reviewed
Nov 12, 2021
adds core methods to create macvlan interface. * Creates macvlan for specified master veth with given mode. * Moves and rename macvlan to container namespace. * Turn up macvlan interface Reference: https://www.cni.dev/plugins/current/main/macvlan/ Signed-off-by: Aditya Rajan <arajan@redhat.com>
flouthoc
force-pushed
the
macvlan_helpers
branch
from
f10ea1d
to
68c16c7
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR makes these following changes
Adds core methods to create macvlan interface.
Cargo.tomlto point tomasterofrtnetlink. After LinkAddRequest: Allow addingmacvlanon a specified link. little-dude/netlink#194