Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIv2 - wrong command and args for created container #8440

Merged
merged 1 commit into from
Nov 23, 2020
Merged

APIv2 - wrong command and args for created container #8440

merged 1 commit into from
Nov 23, 2020

Conversation

psakar
Copy link
Contributor

@psakar psakar commented Nov 21, 2020

fix wrong check for entrypoint which caused wrong path and args for created container
fixes #8433

@psakar
Copy link
Contributor Author

psakar commented Nov 21, 2020

@mheon You was right. It was the place you have pointed at

@psakar
Copy link
Contributor Author

psakar commented Nov 21, 2020

Related to #7927

@psakar psakar mentioned this pull request Nov 21, 2020
Closed
@TomSweeneyRedHat
Copy link
Member

All kinds of test unhappiness, not sure if it's related.

@mheon
Copy link
Member

mheon commented Nov 21, 2020

Theory: the existing code is correct, but we're getting an entrypoint of an empty array (instead of nil), even when the client doesn't pass the entrypoint parameter in the input.

@psakar
Copy link
Contributor Author

psakar commented Nov 22, 2020

@mheon I've seen empty string in entrypoint during debug (in Intellij Idea) AFAICR . I'll try to advance my go skills and debug failing test to see where the problem is.

@psakar
Copy link
Contributor Author

psakar commented Nov 22, 2020

@mheon you was right. Empty value can be provided for entrypoint signaling the image entry point should be overridden.
I've fixed the PR to use nil as default for entrypoint parsed from operation input

@psakar
APIv2 - create container sets wrong entrypoint
c989c19 
use nil instead of empty string as default value for entrypoint in ContainerCLIOpts -
empty string signifies user wants to override image entry point value

Signed-off-by: Petr Sakař <petr.sakar@chare.eu>
@TomSweeneyRedHat
Copy link
Member

LGTM
and happy green test buttons

@rhatdan
Copy link
Member

rhatdan commented Nov 23, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psakar, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2020
@openshift-merge-robot openshift-merge-robot merged commit c61802e into containers:master Nov 23, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

APIv2 - created container has invalid path and args
6 participants
@psakar @TomSweeneyRedHat @mheon @rhatdan @openshift-ci-robot @openshift-merge-robot