Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move solo machine sequence to client state #7271

Merged
merged 4 commits into from
Sep 9, 2020

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Sep 9, 2020

Description

We want to remove height references from the ConsensusState interface and implementations since the height is already being used as the value when looking up consensus states. This is sub pr in achieving that goal.

It moves the sequence to the client state.

ref: #7176


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #7271 into master will decrease coverage by 0.42%.
The diff coverage is 49.74%.

@@            Coverage Diff             @@
##           master    #7271      +/-   ##
==========================================
- Coverage   55.60%   55.17%   -0.43%     
==========================================
  Files         457      584     +127     
  Lines       27440    40536   +13096     
==========================================
+ Hits        15257    22365    +7108     
- Misses      11083    16301    +5218     
- Partials     1100     1870     +770     

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, seems straightforward.

@fedekunze fedekunze merged commit ec74416 into master Sep 9, 2020
@fedekunze fedekunze deleted the colin/remove-height-from-solomachine-consState branch September 9, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants