Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBC testing endpoint should use new SendPacket API #2452

Closed
AdityaSripal opened this issue Sep 30, 2022 · 0 comments · Fixed by #2567
Closed

IBC testing endpoint should use new SendPacket API #2452

AdityaSripal opened this issue Sep 30, 2022 · 0 comments · Fixed by #2567
Assignees
@crodriguezvega
Labels
testing Testing package and unit/integration tests
Milestone
v6.0.0

Comments

@AdityaSripal
Copy link
Member

#1703 improves the SendPacket API so that the packet does not need to be preconstructed by the caller.

The testing library already does this for the most part, and uses Endpoint.SendPacket which still expects the full packet to be sent in.

It would be good to eventually change this to also not require the full packet construction. However, this will generate a lot of diffs since it will touch many ibc tests. We may also want to return the sequence in Endpoint.SendPacket.

I don't believe that this should block 6.0
@AdityaSripal AdityaSripal mentioned this issue Sep 30, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega added the testing Testing package and unit/integration tests label Oct 3, 2022
@crodriguezvega crodriguezvega added this to the v6.0.0 milestone Oct 3, 2022
@crodriguezvega crodriguezvega self-assigned this Oct 20, 2022
@crodriguezvega crodriguezvega mentioned this issue Oct 22, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega linked a pull request Oct 22, 2022 that will close this issue
chore: update tests to use new SendPacket API #2567
Merged
9 tasks
faddat added a commit to notional-labs/ibc-go that referenced this issue Oct 23, 2022
@faddat
Merge remote-tracking branch 'upstream/carlos/cosmos#2452-ibc-testing…
c80ae83 
…-endpoint-should-use-new-sendpacket-api' into 463
@faddat faddat mentioned this issue Oct 23, 2022
Closed
9 tasks
crodriguezvega added a commit that referenced this issue Oct 24, 2022
@crodriguezvega
Merge branch 'main' into carlos/#2452-ibc-testing-endpoint-should-use…
0c933b4 
…-new-sendpacket-api
crodriguezvega added a commit that referenced this issue Oct 24, 2022
@crodriguezvega
Merge branch 'main' into carlos/#2452-ibc-testing-endpoint-should-use…
986bc05 
…-new-sendpacket-api
faddat added a commit to notional-labs/ibc-go that referenced this issue Oct 25, 2022
@faddat
Revert "Merge remote-tracking branch 'upstream/carlos/cosmos#2452-ibc…
8c1efab 
…-testing-endpoint-should-use-new-sendpacket-api' into 463"

This reverts commit c80ae83, reversing
changes made to e4f911c.
crodriguezvega added a commit that referenced this issue Oct 25, 2022
@crodriguezvega
Merge branch 'main' into carlos/#2452-ibc-testing-endpoint-should-use…
cc8c4ef 
…-new-sendpacket-api
crodriguezvega added a commit that referenced this issue Oct 25, 2022
@crodriguezvega
Merge branch 'main' into carlos/#2452-ibc-testing-endpoint-should-use…
5d3b611 
…-new-sendpacket-api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crodriguezvega crodriguezvega

Labels
testing Testing package and unit/integration tests
Projects
ibc-go
Archived in project
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

chore: update tests to use new SendPacket API cosmos/ibc-go
2 participants
@crodriguezvega @AdityaSripal