Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add empty keepers checking in ibc NewKeeper (backport #1284) #1382

Merged
merged 3 commits into from
May 18, 2022
Merged

add empty keepers checking in ibc NewKeeper (backport #1284) #1382

merged 3 commits into from
May 18, 2022

Commits on May 16, 2022

  1. add empty keepers checking in ibc NewKeeper (#1284) 

    * add empty keepers checking in ibc NewKeeper

* check for empty exported keepers instead of empty sdk-defined keeper structs

* Update modules/core/keeper/keeper.go

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* remove func checkEmptyKeepers(), check empty keepers directly within func NewKeeper()

* modules/core/keeper KeeperTestSuite -> MsgServerTestSuite; creat new modules/core/keeper KeeperTestSuite for testing ibckeeper.NewKeeper()

* update CHANGELOG.md

* DummyStakingKeeper -> MockStakingKeeper

* refactor modules/core/keeper test

* Update modules/core/keeper/keeper_test.go

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* Update modules/core/keeper/keeper.go

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
(cherry picked from commit f2577f9)

# Conflicts:
#	CHANGELOG.md
    @catShaark @mergify
    catShaark authored and mergify[bot] committed May 16, 2022
    Configuration menu
    Copy the full SHA
    8d4402e View commit details
    Browse the repository at this point in the history

  2. fix conflict

    @crodriguezvega
    crodriguezvega committed May 16, 2022
    Configuration menu
    Copy the full SHA
    3ca1c8a View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. fix conflict

    @crodriguezvega
    crodriguezvega authored May 17, 2022
    Configuration menu
    Copy the full SHA
    933989f View commit details
    Browse the repository at this point in the history