refactor: panic on ZeroCustomFields for solo machine implementation #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seantking
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
seantking
commented
Aug 10, 2022
| return NewClientState( | ||
| cs.Sequence, cs.ConsensusState, | ||
| ) | ||
| panic("ZeroCustomFields is not implemented as the solo machine implementation does not support upgrades.") |
There was a problem hiding this comment.
Welcome to suggestions for the message here :)
|
Do we want a changelog/update migration docs for this? cc: @colin-axner |
colin-axner
approved these changes
Aug 10, 2022
changelog would be good, migration docs are unnecessary in my opinion. Would just be noise |
damiannolan
approved these changes
Aug 10, 2022
AdityaSripal
approved these changes
Aug 11, 2022
seantking
requested review from
crodriguezvega,
charleenfei and
chatton
as code owners
3 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1885
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes