Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adr 8 callback packet data impl followups #3325

Merged
merged 36 commits into from
Mar 27, 2023

Commits on Mar 14, 2023

  1. remove query client (#3227)

    * remove query client
    
    * merge main
    
    * go mod tidy
    expertdicer authored Mar 14, 2023
    Configuration menu
    Copy the full SHA
    1bdb0e9 View commit details
    Browse the repository at this point in the history
  2. Rename IsBound to HasCapability (#3253)

    ## Description
    
    
    
    closes: #828
    
    
    ### Commit Message / Changelog Entry
    
    ```bash
    imp(api!): rename `IsBound` to `HasCapability` for IBC application modules
    ```
    
    see the [guidelines](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) for commit messages. (view raw markdown for examples)
    
    
    
    
    ---
    
    Before we can merge this PR, please make sure that all the following items have been
    checked off. If any of the checklist items are not applicable, please leave them but
    write a little note why.
    
    - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#pull-request-targeting)).
    - [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
    - [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/10-structure.md) and [Go style guide](../docs/dev/go-style-guide.md).
    - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/main/testing/README.md#ibc-testing-package).
    - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`).
    - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
    - [ ] Provide a [commit message](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) to be used for the changelog entry in the PR description for review.
    - [ ] Re-reviewed `Files changed` in the Github PR explorer.
    - [ ] Review `Codecov Report` in the comment section below once CI passes.
    expertdicer authored Mar 14, 2023
    Configuration menu
    Copy the full SHA
    be4c2d0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    036565a View commit details
    Browse the repository at this point in the history
  4. build(deps): bump cosmossdk.io/math from 1.0.0-beta.6.0.2023021617212…

    …1-959ce49135e4 to 1.0.0-rc.0 (#3285)
    
    Bumps [cosmossdk.io/math](https://github.com/cosmos/cosmos-sdk) from 1.0.0-beta.6.0.20230216172121-959ce49135e4 to 1.0.0-rc.0.
    <details>
    <summary>Commits</summary>
    <ul>
    <li>See full diff in <a href="https://github.com/cosmos/cosmos-sdk/commits/math/v1.0.0-rc.0">compare view</a></li>
    </ul>
    </details>
    <br />
    
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=cosmossdk.io/math&package-manager=go_modules&previous-version=1.0.0-beta.6.0.20230216172121-959ce49135e4&new-version=1.0.0-rc.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    
    </details>
    dependabot[bot] authored Mar 14, 2023
    Configuration menu
    Copy the full SHA
    80bab81 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2cb28d7 View commit details
    Browse the repository at this point in the history
  6. chore: fix dead links (#3293)

    ## Description
    
    
    
    closes: #XXXX
    
    
    ### Commit Message / Changelog Entry
    
    ```bash
    type: commit message
    ```
    
    see the [guidelines](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) for commit messages. (view raw markdown for examples)
    
    
    
    
    ---
    
    Before we can merge this PR, please make sure that all the following items have been
    checked off. If any of the checklist items are not applicable, please leave them but
    write a little note why.
    
    - [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#pull-request-targeting)).
    - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
    - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/10-structure.md) and [Go style guide](../docs/dev/go-style-guide.md).
    - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/main/testing/README.md#ibc-testing-package).
    - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`).
    - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
    - [ ] Provide a [commit message](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) to be used for the changelog entry in the PR description for review.
    - [x] Re-reviewed `Files changed` in the Github PR explorer.
    - [ ] Review `Codecov Report` in the comment section below once CI passes.
    crodriguezvega authored Mar 14, 2023
    Configuration menu
    Copy the full SHA
    02d8975 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Configuration menu
    Copy the full SHA
    796c7bc View commit details
    Browse the repository at this point in the history
  2. deps: bump SDK v0.47 (#3295)

    Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
    3 people authored Mar 15, 2023
    Configuration menu
    Copy the full SHA
    71e8bf4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    94d74f9 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. Configuration menu
    Copy the full SHA
    b502f47 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6be595a View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Configuration menu
    Copy the full SHA
    85faf55 View commit details
    Browse the repository at this point in the history
  2. Remove gogoproto yaml tags from proto files (#3290)

    ## Description
    Refer from original issue, I removed all `yaml` tags in proto files.
    
    closes: #3145 
    
    
    ### Commit Message / Changelog Entry
    
    ```bash
    type: commit message
    ```
    
    see the [guidelines](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) for commit messages. (view raw markdown for examples)
    
    
    
    
    ---
    
    Before we can merge this PR, please make sure that all the following items have been
    checked off. If any of the checklist items are not applicable, please leave them but
    write a little note why.
    
    - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#pull-request-targeting)).
    - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
    - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/10-structure.md) and [Go style guide](../docs/dev/go-style-guide.md).
    - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/main/testing/README.md#ibc-testing-package).
    - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`).
    - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
    - [ ] Provide a [commit message](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) to be used for the changelog entry in the PR description for review.
    - [ ] Re-reviewed `Files changed` in the Github PR explorer.
    - [ ] Review `Codecov Report` in the comment section below once CI passes.
    hieuvubk authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    b4a386a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b3f1b4d View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Configuration menu
    Copy the full SHA
    cbb6859 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    89ecf25 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    88f3c3c View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Configuration menu
    Copy the full SHA
    5a67efc View commit details
    Browse the repository at this point in the history
  2. ADR 008: IBC Actor Callbacks (#1976)

    * context and decision
    
    * complete adr
    
    * Apply suggestions from code review
    
    Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
    
    * change from caller to generalized actor
    
    * Apply suggestions from code review
    
    Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
    
    * create folder and scaffolded middleware
    
    * add error handling and generify packetdata interface
    
    * complete renaming
    
    * add user defined gas limit and clarify pseudocode
    
    * Clarify CallbackPacketData interface
    
    imp: Add ADR 008: IBC Actor Callbacks
    
    ---------
    
    Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
    Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
    3 people authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    7d23e0f View commit details
    Browse the repository at this point in the history
  3. lint: fix spelling

    colin-axner committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    8c16ce0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2818a57 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8e8c64a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3cdc8b3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    be5a766 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    767c5af View commit details
    Browse the repository at this point in the history
  9. imp: address ADR 8 review suggestions (#3319)

    
    ---------
    
    Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    colin-axner and damiannolan authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    12c00ec View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Bump interchain test (#3314)

    chatton authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    4961826 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a02ec51 View commit details
    Browse the repository at this point in the history
  3. fix: build + linting

    colin-axner committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    6f25b8e View commit details
    Browse the repository at this point in the history
  4. Only run e2e on R4R (#3330)

    chatton authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    f4c20e4 View commit details
    Browse the repository at this point in the history
  5. fix fork workflows (#3328)

    chatton authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    8971ffc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1c6164b View commit details
    Browse the repository at this point in the history
  7. Revert "Merge branch 'main' of github.com:cosmos/ibc-go into colin/ca…

    …llback-packet-data-impl"
    
    This reverts commit 1c6164b, reversing
    changes made to 6f25b8e.
    colin-axner committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    9435525 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7f88419 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Apply suggestions from code review

    Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
    colin-axner and crodriguezvega authored Mar 27, 2023
    Configuration menu
    Copy the full SHA
    935c5f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a1252f3 View commit details
    Browse the repository at this point in the history