Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add deprecated option to MsgSubmitMisbehaviour #3893

Merged

Conversation

crodriguezvega
Copy link
Contributor

Description

The messages was deprecated with 02-client refactor. This PR sets the deprecated option for the whole message, instead of the individual fields of the message.

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar micro-nit as the other, other than that, lgtm

@colin-axner colin-axner added the type: code hygiene Clean up code but without changing functionality or interfaces label Jun 19, 2023
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Much better than 3 field options 😅

@codecov-commenter
Copy link

Codecov Report

Merging #3893 (888881d) into main (735f81e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3893   +/-   ##
=======================================
  Coverage   78.87%   78.88%           
=======================================
  Files         187      187           
  Lines       12939    12944    +5     
=======================================
+ Hits        10206    10211    +5     
  Misses       2305     2305           
  Partials      428      428           
Impacted Files Coverage Δ
...les/apps/27-interchain-accounts/host/types/msgs.go 100.00% <100.00%> (ø)
modules/apps/transfer/keeper/keeper.go 90.47% <100.00%> (ø)
modules/apps/transfer/keeper/relay.go 90.90% <100.00%> (ø)
modules/apps/transfer/types/packet.go 100.00% <100.00%> (ø)
...ules/apps/transfer/types/transfer_authorization.go 92.04% <100.00%> (ø)

@crodriguezvega crodriguezvega merged commit 255c5e2 into main Jun 20, 2023
@crodriguezvega crodriguezvega deleted the carlos/add-deprecated-option-msgsubmitmisbehaviour branch June 20, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants