Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove ica storekey #4677

Merged
merged 11 commits into from
Sep 19, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 16, 2023

Description

Remove ICA StoreKey

closes: #4644

Commit Message / Changelog Entry

chore: remove ica storekey

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @faddat. Would it be possible to take all the module bumps out of this PR?

modules/apps/27-interchain-accounts/module.go Show resolved Hide resolved
@damiannolan damiannolan self-assigned this Sep 18, 2023
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @faddat, lgtm! 🚀

modules/apps/27-interchain-accounts/module.go Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #4677 (aafdc85) into main (82d66ad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4677   +/-   ##
=======================================
  Coverage   79.65%   79.66%           
=======================================
  Files         187      187           
  Lines       13195    13196    +1     
=======================================
+ Hits        10511    10512    +1     
  Misses       2253     2253           
  Partials      431      431           
Files Changed Coverage Δ
modules/apps/27-interchain-accounts/types/keys.go 100.00% <ø> (ø)
modules/apps/27-interchain-accounts/module.go 49.50% <100.00%> (+0.50%) ⬆️

@damiannolan damiannolan enabled auto-merge (squash) September 19, 2023 09:38
@damiannolan damiannolan merged commit 10c4a02 into cosmos:main Sep 19, 2023
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused StoreKey from icatypes
6 participants