ICS 28: WASM Client #506
ICS 28: WASM Client #506
Conversation
…changes; general clarification
…dling; proto3 schemas
* Fix 24/getConsensusState Under `getConsensusState`, > `getConsensusState` MUST return the consensus state for the consensus algorithm of the host chain at the specified height, for all heights greater than zero and less than or equal to the current height. For some cases `getConsensusState` will not be able to return the consensus state with height of `0 < _ < current`. For efficiency, the chains might choose to prune the states and (if the pruning happens for past enough states) the impl will still work, so the restriction should be RECOMMENDED. * Update README.md
spec/ics-028-wasm-client/README.md
Outdated
| height: Height, | ||
| proof: CommitmentPrefix) { | ||
| codeHandle = clientState.codeHandle() | ||
| codeHandle.verifyNewClientState(oldClientState, newClientState, height) |
There was a problem hiding this comment.
I generally like this proposal and level of detail.
However, I am trying to visualize what the full API of the contract is, and it is rather hard to do with the codeHandle.xxx() calls scattered around. Could you add a section listing the API with argument types of the wasm verifier? Also whether it is a pure function or whether we assume it can read local state / query chain state.
There was a problem hiding this comment.
I have added clarification on how code handle will be implemented, as well as WASM interface that need to be supported by every WASM based light client contract.
It should be pure function, there should not be any need to read local state/query chain state.
There was a problem hiding this comment.
Thanks for the PR! See my comment on the corresponding ADR - cosmos/cosmos-sdk#8035 (review) - this security model should be detailed in this spec document explicitly and followed by the implementation.
|
Can you move this to https://github.com/cosmos/ibc ? |
|
Should this still be open? |
|
Yes, it can be reopened now, sorry for all the confusion. Alas I do not seem to be able to do this, but feel free to. |
|
I can't re-open, maybe @milosevic or @AdityaSripal ? |
|
Can't reopen because the branch has no history in common with master. Maybe Parth can manually open a new PR? Sorry for the inconvenience |
|
Ok. Will do it.
On Fri, 30 Apr 2021 at 10:30 PM, Aditya ***@***.***> wrote:
Can't reopen because the branch has no history in common with master.
Maybe Parth can manually open a new PR? Sorry for the inconvenience
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#506 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASLNM3FPA2HB4TLYTK53JDTLLZK7ANCNFSM4UDZANJQ>
.
--
Cheers,
Parth Desai
Polyglot software developer and architect.
|
|
Sorry for the delay. It is re-opened.
On Fri, 30 Apr 2021 at 10:40 PM, Parth Desai ***@***.***> wrote:
Ok. Will do it.
On Fri, 30 Apr 2021 at 10:30 PM, Aditya ***@***.***> wrote:
> Can't reopen because the branch has no history in common with master.
> Maybe Parth can manually open a new PR? Sorry for the inconvenience
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#506 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AASLNM3FPA2HB4TLYTK53JDTLLZK7ANCNFSM4UDZANJQ>
> .
>
--
Cheers,
Parth Desai
Polyglot software developer and architect.
--
Cheers,
Parth Desai
Polyglot software developer and architect.
|
No description provided.