Fix ordered channel timeouts #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agouin
requested review from
jackzampolin,
jtieri,
boojamya and
mark-rushakoff
as code owners
agouin
added a commit
that referenced
this pull request
Nov 16, 2022
agouin
added a commit
that referenced
this pull request
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple
send_packetmessages on an ordered channel have the same timeout, and that timeout expires, the timeout for the next packet (lowest sequence) was not being relayed because it was attempting to batch multiple timeouts in the same transaction.This makes sure that all packet messages are handled on a next sequence only basis.