Attempting to use goreleaser-cross #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeabbey
requested review from
jackzampolin,
jtieri,
boojamya and
mark-rushakoff
as code owners
agouin
reviewed
Dec 14, 2022
.github/workflows/release.yml
Outdated
| args: release --rm-dist | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: release dry run |
There was a problem hiding this comment.
is there a reason the dry-run is necessary here?
There was a problem hiding this comment.
ah, not really.. removing!
agouin
approved these changes
Dec 14, 2022
agouin
pushed a commit
that referenced
this pull request
Dec 14, 2022
* Attempting to use goreleaser-cross * Removing linux amd64 env * binary is rly * Ignore the .release-env and dist/ directory * Removing dry-run before release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.