Harry/wallet init

[Cosmos-Harry]

• Added a new flag --restore-all
• Without the flag, the args work normally but with the flag chain_name is not needed and the order has changed
• closes initialize wallets command #1030

[jtieri]

I had a few comments but nothing major, changes mostly look good. This will be a nice feature to have!

One request I do have is can we get a test case added for this?
There are some existing tests in keys_test.go, perhaps create a new test case based on the existing test

relayer/cmd/keys_test.go

Lines 38 to 78 in cb4708b

	func TestKeysRestore_Delete(t *testing.T) {
	t.Parallel()
	sys := relayertest.NewSystem(t)
	_ = sys.MustRun(t, "config", "init")
	slip44 := 118
	sys.MustAddChain(t, "testChain", cmd.ProviderConfigWrapper{
	Type: "cosmos",
	Value: cosmos.CosmosProviderConfig{
	AccountPrefix: "cosmos",
	ChainID: "testcosmos",
	KeyringBackend: "test",
	Timeout: "10s",
	Slip44: &slip44,
	},
	})
	// Restore a key with mnemonic to the chain.
	res := sys.MustRun(t, "keys", "restore", "testChain", "default", relayertest.ZeroMnemonic)
	require.Equal(t, res.Stdout.String(), relayertest.ZeroCosmosAddr+"\n")
	require.Empty(t, res.Stderr.String())
	// Restored key must show up in list.
	res = sys.MustRun(t, "keys", "list", "testChain")
	require.Equal(t, res.Stdout.String(), "key(default) -> "+relayertest.ZeroCosmosAddr+"\n")
	require.Empty(t, res.Stderr.String())
	// Deleting the key must succeed.
	res = sys.MustRun(t, "keys", "delete", "testChain", "default", "-y")
	require.Empty(t, res.Stdout.String())
	require.Equal(t, res.Stderr.String(), "key default deleted\n")
	// Listing the keys again gives the no keys warning.
	res = sys.MustRun(t, "keys", "list", "testChain")
	require.Empty(t, res.Stdout.String())
	require.Contains(t, res.Stderr.String(), "no keys found for chain testChain")
	}

[Cosmos-Harry]

I had a few comments but nothing major, changes mostly look good. This will be a nice feature to have!

One request I do have is can we get a test case added for this? There are some existing tests in keys_test.go, perhaps create a new test case based on the existing test

relayer/cmd/keys_test.go

Lines 38 to 78 in cb4708b

	func TestKeysRestore_Delete(t *testing.T) {
	t.Parallel()
	sys := relayertest.NewSystem(t)
	_ = sys.MustRun(t, "config", "init")
	slip44 := 118
	sys.MustAddChain(t, "testChain", cmd.ProviderConfigWrapper{
	Type: "cosmos",
	Value: cosmos.CosmosProviderConfig{
	AccountPrefix: "cosmos",
	ChainID: "testcosmos",
	KeyringBackend: "test",
	Timeout: "10s",
	Slip44: &slip44,
	},
	})
	// Restore a key with mnemonic to the chain.
	res := sys.MustRun(t, "keys", "restore", "testChain", "default", relayertest.ZeroMnemonic)
	require.Equal(t, res.Stdout.String(), relayertest.ZeroCosmosAddr+"\n")
	require.Empty(t, res.Stderr.String())
	// Restored key must show up in list.
	res = sys.MustRun(t, "keys", "list", "testChain")
	require.Equal(t, res.Stdout.String(), "key(default) -> "+relayertest.ZeroCosmosAddr+"\n")
	require.Empty(t, res.Stderr.String())
	// Deleting the key must succeed.
	res = sys.MustRun(t, "keys", "delete", "testChain", "default", "-y")
	require.Empty(t, res.Stdout.String())
	require.Equal(t, res.Stderr.String(), "key default deleted\n")
	// Listing the keys again gives the no keys warning.
	res = sys.MustRun(t, "keys", "list", "testChain")
	require.Empty(t, res.Stdout.String())
	require.Contains(t, res.Stderr.String(), "no keys found for chain testChain")
	}

I have made the suggested changes, please let me know if they are correct, thank you!

[jtieri]

looks good! thanks for the contribution 🙂