Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: packet get relayed even estimated gas is higher than max gas #1302

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Problem: packet get relayed even estimated gas is higher than max gas #1302

merged 5 commits into from
Oct 11, 2023

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Oct 6, 2023

to align estimate fee behaviour with hermes

mmsqe
mmsqe commented Oct 6, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
jtieri
jtieri reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should possibly add the check back that i point out in the review but other than that this lgtm

relayer/chains/cosmos/tx.go Show resolved Hide resolved
relayer/chains/cosmos/tx.go Outdated Show resolved Hide resolved
jtieri
jtieri approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jtieri jtieri merged commit 892e52c into cosmos:main Oct 11, 2023
17 checks passed
@jtieri jtieri mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtieri jtieri jtieri approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@boojamya boojamya Awaiting requested review from boojamya

@mark-rushakoff mark-rushakoff Awaiting requested review from mark-rushakoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmsqe @jtieri