Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pipe memo from cli to broadcast tx logic for MsgTransfer and MsgRegisterCounterpartyPayee #1362

Merged
merged 2 commits into from
Dec 14, 2023
Merged

fix: pipe memo from cli to broadcast tx logic for MsgTransfer and MsgRegisterCounterpartyPayee #1362

merged 2 commits into from
Dec 14, 2023

Conversation

jtieri
Copy link
Member

@jtieri jtieri commented Dec 13, 2023 •
edited
Loading

Previously we were failing to register the --memo flag for the rly tx transfer and rly tx register-counterparty cmds.

We were also failing to pipe the memo from the CLI through to the broadcast tx logic where the memo is actually set on the tx before attempting to broadcast it to the network.

This PR also fixes a bunch of linter errors that golangci-lint was complaining about.

Closes #1351

@jtieri jtieri added T: Bug 🪲 TYPE: Inconsistencies or issues which will cause an issue or problem for users or implementors. C: CLI COMPONENT: Command-Line Interface labels Dec 13, 2023
@jtieri jtieri marked this pull request as ready for review December 13, 2023 22:11
@jtieri jtieri mentioned this pull request Dec 13, 2023
Closed
@jtieri jtieri enabled auto-merge (squash) December 13, 2023 22:31
@jtieri jtieri self-assigned this Dec 13, 2023
boojamya
boojamya approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@boojamya boojamya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Good eye on getting it in the registerCounterpartyCmd as well.

@jtieri jtieri merged commit 654ea9f into main Dec 14, 2023
19 checks passed
@jtieri jtieri deleted the justin/fix-transfer-memo branch December 14, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojamya boojamya boojamya approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@mark-rushakoff mark-rushakoff Awaiting requested review from mark-rushakoff

Assignees

@jtieri jtieri

Labels
C: CLI COMPONENT: Command-Line Interface T: Bug 🪲 TYPE: Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

memo entry in not populated for transactions via the relayer
2 participants
@jtieri @boojamya