Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing for edx multiple sections #590

Merged

Conversation

Oshibuki
Copy link
Contributor

Fixes #589

🚨Please review the guidelines for contributing to this repository.

Proposed changes

  • fix mutiple section class selector.
  • fix section name getter

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I agree to contribute my changes under the project's LICENSE
  • I have checked that the unit tests pass locally with my changes
  • I have checked the style of the new code (lint/pep).
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, please explain why you chose
the solution you did and what alternatives you considered, etc.

Reviewers

If you know the person who can review your code please add a @mention.

@fliker09
Copy link

Thank you, worked like a charm!

@balta2ar balta2ar merged commit 81e9fbc into coursera-dl:master Feb 25, 2020
balta2ar added a commit that referenced this pull request Feb 25, 2020
    Bugfixes:
    - Fix section layouts (fix #591, #590)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using edx-dl 0.1.12 , Still downloading empty folder structure, Issue #587 not yet resolved..
3 participants