Fix v-model not working

cristijora · Jul 30, 2017 · e4d2f6f · e4d2f6f
1 parent 49358cb
commit e4d2f6f
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 38 deletions.
diff --git a/dev/App.vue b/dev/App.vue
@@ -2,22 +2,16 @@
   <div>
     <vue-tabs class="card" @on-error="handleError"
               v-model="tabName">
-      <!--<template slot="tab" scope="props">
-        <li :class="{active:props.tab.active}" >
-          <a href="" @click.prevent="props.clickHandler(props.index)" style="border-radius:50%">
-           {{props.tab.title}}
-          </a>
-        </li>
-      </template>-->
-      <v-tab v-for="(re, index) in reList"
-             :key="re.name"
-             :title="re.name"
+      <v-tab v-for="(tab, index) in tabList"
+             :key="tab.name"
+             :title="tab.name"
              icon="ti-user">
-        {{re.name}}
+        {{tab.name}}
       </v-tab>
     </vue-tabs>
-    <button @click="reList.push({name:'test'})">Add more!</button>
-    <button @click="reList.splice(0,1)">Remove first</button>
+    <button @click="tabList.push({name:'test'})">Add more!</button>
+    <button @click="tabList.splice(0,1)">Remove first</button>
+    <button @click="goToSecondTab">Go to second tab</button>
   </div>
 </template>
 
@@ -27,17 +21,17 @@
     name: 'app',
     data(){
       return {
-        reList : [],
-        tabName: 'name2'
+        tabList : [{name:'name1'},{name:'name2'},{name:'name3'}],
+        tabName: 'name1'
       }
     },
     methods: {
       handleError(error){
         this.error = error
+      },
+      goToSecondTab(){
+          this.tabName='name2'
       }
-    },
-    mounted () {
-      this.reList = [{name:'name1'},{name:'name2'},{name:'name3'}]
     }
   }
 </script>

diff --git a/dist/vue-tabs.common.js b/dist/vue-tabs.common.js
@@ -110,9 +110,9 @@ var VueTabs = {
             }
             return [];
         },
-        findTabAndActivate: function findTabAndActivate(tabName) {
-            var indexToActivate = this.tabs.findIndex(function (tab) {
-                return tab.title === tabName;
+        findTabAndActivate: function findTabAndActivate(tabNameOrIndex) {
+            var indexToActivate = this.tabs.findIndex(function (tab, index) {
+                return tab.title === tabNameOrIndex || index === tabNameOrIndex;
             });
             if (indexToActivate != -1) {
                 this.changeTab(this.activeTabIndex, indexToActivate);
@@ -237,10 +237,10 @@ var VueTabs = {
             if (newList.length > 0 && this.value) {
                 this.findTabAndActivate(this.value);
             }
+        },
+        value: function value(newVal) {
+            this.findTabAndActivate(newVal);
         }
-    },
-    value: function value(newVal) {
-        this.findTabAndActivate(newVal);
     }
 };
 

diff --git a/dist/vue-tabs.js b/dist/vue-tabs.js
@@ -112,9 +112,9 @@ var VueTabs = {
             }
             return [];
         },
-        findTabAndActivate: function findTabAndActivate(tabName) {
-            var indexToActivate = this.tabs.findIndex(function (tab) {
-                return tab.title === tabName;
+        findTabAndActivate: function findTabAndActivate(tabNameOrIndex) {
+            var indexToActivate = this.tabs.findIndex(function (tab, index) {
+                return tab.title === tabNameOrIndex || index === tabNameOrIndex;
             });
             if (indexToActivate != -1) {
                 this.changeTab(this.activeTabIndex, indexToActivate);
@@ -239,10 +239,10 @@ var VueTabs = {
             if (newList.length > 0 && this.value) {
                 this.findTabAndActivate(this.value);
             }
+        },
+        value: function value(newVal) {
+            this.findTabAndActivate(newVal);
         }
-    },
-    value: function value(newVal) {
-        this.findTabAndActivate(newVal);
     }
 };
 

diff --git a/dist/vue-tabs.min.js b/dist/vue-tabs.min.js