Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add simulated vote results #2732

Open
CrowbarToolsRobot opened this issue Aug 23, 2024 · 2 comments
Open

[Feature Request] Add simulated vote results #2732

CrowbarToolsRobot opened this issue Aug 23, 2024 · 2 comments
Labels
Dev Complete Enhancement A feature request or improvement Ready For Review Issue has a PR opened and is undergoing dev review.

Comments

@CrowbarToolsRobot
Copy link
Collaborator

Description

When using "Simulate Event" to simulate a "Channel Poll Ending", I should be able to add poll result names and vote counts for testing $pollWinningChoiceName and $pollWinningChoiceVotes. Currently I can only add "Title" which also doesn't seem accessible via $vars.

Submitted By

spex.dev

Created via Discord.
@CrowbarToolsRobot CrowbarToolsRobot added the Enhancement A feature request or improvement label Aug 23, 2024
@phroggster phroggster mentioned this issue Aug 23, 2024
Merged
@phroggster phroggster added Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release labels Aug 24, 2024
@phroggster
Copy link
Collaborator

The $pollWinningChoiceName and $pollWinningChoiceVotes variables will gain simulated event data in an upcoming release.

It looks like we still have some work to do on getting the poll choices and the poll title exposed to variables, and I'll see what I can do about that this weekend.

@phroggster phroggster removed Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release labels Aug 24, 2024
phroggster added a commit to phroggster/Firebot that referenced this issue Sep 1, 2024
@phroggster
feat: Add $pollChoices and $pollTitle variables
bd811b9 
- $pollChoices provides for just about every imaginable piece of info
  about polling options for Poll Started, Poll Progress, and Poll Ended
  events.
- Meanwhile, $pollTitle is a bit more focused for just the title of a
  poll.
- Fix mismatched metadata for the poll-progress and poll-end events.
- Implements the remaining bits of crowbartools#2732
@phroggster phroggster mentioned this issue Sep 3, 2024
Open
@phroggster phroggster added Dev Complete Ready For Review Issue has a PR opened and is undergoing dev review. labels Sep 3, 2024
@phroggster
Copy link
Collaborator

The PR proposed adds variables for accessing the poll choices and the poll title. However, the simulate event interface is incompatible with injecting an array of poll choices, but manually using "Test Effects" will include three simulated poll options. This does not solve the initial request (allow manually specifying polling data in a simulated event), but it would fix the remainder of secondary complaints listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dev Complete Enhancement A feature request or improvement Ready For Review Issue has a PR opened and is undergoing dev review.
Projects
Firebot
Status: Code Review
Work Status
Status: In Code Review
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phroggster @CrowbarToolsRobot