Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: quote id effect output (#2822) #2823

Merged

Conversation

dennisrijsdijk
Copy link
Collaborator

Description of the Change

Adds an effect output to the "Add Quote" effect for the quote ID of the created quote. ($&quoteId)
Converts effect to typescript

Applicable Issues

#2822

Testing

Ensured effect runs, properly creates quote and returns the new quote's ID as an effect output ($&quoteId)

Copy link
Member

@CaveMobster CaveMobster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition!

@CaveMobster CaveMobster merged commit 954a9e3 into crowbartools:v5 Sep 24, 2024
1 check passed
@dennisrijsdijk dennisrijsdijk deleted the feat/quote-effect-output-id branch September 24, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants