Football - Adding Nominating Team as Attribute to Pick Class

[ctmarxen]

I'd love to determine auction tendencies in terms of how often the nominating team ends up winning the nominated player. Any chance you could add this attribute (i.e. nominating team) to the Pick class so that for any player you can find the team who nominated the player?

[cwendt94]

Hey @ctmarxen I'm not 100% familiar with auction drafts (only have experience with auction waiver wire) and currently not part of one. I would love to help and see if this can be added to the Pick class.

Would you be able to get a sample of the draft data? There are two ways you could get the data

1. Can add a print statement here of the picks object
2. Can run package in debug mode and search the logs for mDraftDetail

The first option would be the easiest because in debug mode it will print out all API calls made with their response objects so its a little harder to parse logs.

[cwendt94]

No worries this is great! So from that example all of the nominatingTeamID equal 0 which does not map to a team. What does that mean for the pick?

To get the team class from the nominatingTeamID you can follow this line and add something like this

nominatingTeam = self.get_team_data(pick['nominatingTeamID'])

The value could be None

[ctmarxen]

Ahh this is great! So the reason why the nominatingTeamID is 0 for those picks is that they were actually keepers (players kept from the previous year). Take a look at the picks once we get beyond the keepers:

[ctmarxen]

I made the updates to league.py and pick.py here: https://github.com/ctmarxen/espn-api/tree/master/espn_api/football
I don't know how to test the changes though before submitting a pull request. I guess, how do I test the changes locally using this updated api rather than the original one (using Pycharm)?

[cwendt94]

That makes sense, I didn't even realize the keeper value had true. You can test locally running this command in the repo

python3 setup.py nosetests

I will take a look at PR and can give suggestions on how to test

[ctmarxen]

Stinking key error, I used 'nominatingTeamID' rather than 'nominatingTeamId'...Hopefully the branch passes the tests now (I also made the changes you suggested)