Saner defaults for configs (grafana#2344)

* Saner defaults for configs Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Set spread_flushes to true in the code. Signed-off-by: Tom Wilkie <tom@grafana.com> * Make mockIngester implement HealthCheck and io.Closer so tests pass. Signed-off-by: Tom Wilkie <tom@grafana.com> * Address feedback Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Verify that querier sees correct ring before using it. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Address feedback Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> Co-authored-by: Tom Wilkie <tom@grafana.com> Co-authored-by: Peter Štibraný <peter.stibrany@grafana.com>
cyriltovena · Mar 30, 2020 · e27b797 · e27b797
1 parent 6413dbc
commit e27b797
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cache/memcached.go b/cache/memcached.go
@@ -50,7 +50,7 @@ type MemcachedConfig struct {
 // RegisterFlagsWithPrefix adds the flags required to config this to the given FlagSet
 func (cfg *MemcachedConfig) RegisterFlagsWithPrefix(prefix, description string, f *flag.FlagSet) {
 	f.DurationVar(&cfg.Expiration, prefix+"memcached.expiration", 0, description+"How long keys stay in the memcache.")
-	f.IntVar(&cfg.BatchSize, prefix+"memcached.batchsize", 0, description+"How many keys to fetch in each batch.")
+	f.IntVar(&cfg.BatchSize, prefix+"memcached.batchsize", 1024, description+"How many keys to fetch in each batch.")
 	f.IntVar(&cfg.Parallelism, prefix+"memcached.parallelism", 100, description+"Maximum active requests to memcache.")
 }
 

diff --git a/cache/memcached_client.go b/cache/memcached_client.go
@@ -75,7 +75,7 @@ func (cfg *MemcachedClientConfig) RegisterFlagsWithPrefix(prefix, description st
 	f.IntVar(&cfg.MaxIdleConns, prefix+"memcached.max-idle-conns", 16, description+"Maximum number of idle connections in pool.")
 	f.DurationVar(&cfg.Timeout, prefix+"memcached.timeout", 100*time.Millisecond, description+"Maximum time to wait before giving up on memcached requests.")
 	f.DurationVar(&cfg.UpdateInterval, prefix+"memcached.update-interval", 1*time.Minute, description+"Period with which to poll DNS for memcache servers.")
-	f.BoolVar(&cfg.ConsistentHash, prefix+"memcached.consistent-hash", false, description+"Use consistent hashing to distribute to memcache servers.")
+	f.BoolVar(&cfg.ConsistentHash, prefix+"memcached.consistent-hash", true, description+"Use consistent hashing to distribute to memcache servers.")
 }
 
 // NewMemcachedClient creates a new MemcacheClient that gets its server list