Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow commenting out backend.cfg #988

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

userwiths
Copy link

Regarding issue #950

Did not see any processing regarding if the option is commented out or not. Now we check if the first symbol is a semicolon (;) and in case it is, we return default rather than the commented out option.

I did test this locally, and it seems the issue was purely visual.
When the semicolon (;) is present, we can see a message like this
[WARN] [second.loc] Backend rewrite config is invalid: Invalid backend string ';conf:phpfpm:tcp:php81:9000'. It must start with 'conf:'
In the Command & Control tab which stops the app from using the commented out backend and uses the default one.

Regarding issue [cytopia#950](cytopia#950)

Did not see any processing regarding if the option is commented out or not.
Now we check if the first symbol is a semicolon (;) and in case it is, we return `default` rather than the commented out option.
@Ernestopheles
Copy link
Contributor

Commenting Out the Option ist useful, as it disables it. Please keep this possibility !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants