Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Cloudflare guide update with example #943

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rmarscher
Copy link
Contributor

Moving a code example for Cloudflare to Waku so we don't need to reference my public gist and it's easier for everyone to test.

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
waku ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 6:01pm

Copy link

codesandbox-ci bot commented Oct 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this!

check ci errors pls.

Comment on lines +13 to +18
"hono": "^4.6.3",
"react": "19.0.0-rc-2d16326d-20240930",
"react-dom": "19.0.0-rc-2d16326d-20240930",
"react-server-dom-webpack": "19.0.0-rc-2d16326d-20240930",
"waku": "0.21.3",
"wrangler": "^3.80.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we pin versions.

Suggested change
"hono": "^4.6.3",
"react": "19.0.0-rc-2d16326d-20240930",
"react-dom": "19.0.0-rc-2d16326d-20240930",
"react-server-dom-webpack": "19.0.0-rc-2d16326d-20240930",
"waku": "0.21.3",
"wrangler": "^3.80.0"
"hono": "4.6.3",
"react": "19.0.0-rc-2d16326d-20240930",
"react-dom": "19.0.0-rc-2d16326d-20240930",
"react-server-dom-webpack": "19.0.0-rc-2d16326d-20240930",
"waku": "0.21.3",
"wrangler": "3.80.0"

Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename 26_cloudflare to 44_cloudflare and add entries in package.json "scripts".

@rmarscher
Copy link
Contributor Author

Thank you. I will make these updates after I fix #944. Switching to draft for now.

@rmarscher rmarscher marked this pull request as draft October 6, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants