Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for recent Node.js versions and Effective TypeScript #53

Merged
merged 7 commits into from
Feb 4, 2023
Merged

Fixes for recent Node.js versions and Effective TypeScript #53

merged 7 commits into from
Feb 4, 2023

Conversation

danvk
Copy link
Owner

@danvk danvk commented Feb 4, 2023 •
edited
Loading

I ran the latest literate-ts against the Effective TypeScript source for the first time in a while today and ran into some issues. This fixes them.

  1. Newer versions of Node include a version number on stderr when they log a stack trace. This filters that out.
  2. I put lots of fenced code blocks in comments in the Effective TypeScript source. These weren't checked until Added triple-tick codeblock support to asciidoc processor #36. Most of them didn't pass the checker. Since these are mostly just "note to self" and not intended to be checked, I added an undocumented directive to disable checking them.

@danvk danvk changed the title Strip node version from error output Fixes for recent Node.js versions and Effective TypeScript Feb 4, 2023
@danvk danvk merged commit 08217df into master Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danvk